Re: java.util.Base64 accepts non-canonical encodings

2020-06-23 Thread Raffaello Giulietti
OK, I'll avoid the checks in the patch intended for general publication but will add them separately just to see which of current tests would fail. I'll then later open a separate issue for discussing a possible extension of the API and a possible CSR. Greetings Raffaello On 2020-06-23 17:

Re: java.util.Base64 accepts non-canonical encodings

2020-06-23 Thread Roger Riggs
Hi, This is a case where having some more interoperability testing could be informative though there are likely many adhoc Base64 encoders and its not practical to test against them. Introducing a new mode or option creates an undesirable fuzzyness to the API. It won't help existing uses w

Re: java.util.Base64 accepts non-canonical encodings

2020-06-23 Thread Roger Riggs
Hi Raffaello, I think the concern over accepting non-canonical encodings would be compatibility. It would rude to implement the strictness and have applications start failing. But it is likely an oversight since existing code checks for other invalid encodings. Do any of the existing tests f