Re: RFR java.time serialization

2013-12-16 Thread Stephen Colebourne
Looks fine AFAICT Stephen On 17 Dec 2013 09:23, "roger riggs" wrote: > Hi Sherman, > > Thanks for the comments, corrected and updated the webrev: > http://cr.openjdk.java.net/~rriggs/webrev-time-serialization/ > > On 12/16/2013 1:00 PM, Xueming Shen wrote: > >> On 12/16/2013 09:02 AM, roger rig

Re: RFR java.time serialization

2013-12-16 Thread roger riggs
Hi Sherman, Thanks for the comments, corrected and updated the webrev: http://cr.openjdk.java.net/~rriggs/webrev-time-serialization/ On 12/16/2013 1:00 PM, Xueming Shen wrote: On 12/16/2013 09:02 AM, roger riggs wrote: Please review these changes to java.time serialization. The format of the

Re: RFR java.time serialization

2013-12-16 Thread Xueming Shen
On 12/16/2013 09:02 AM, roger riggs wrote: Please review these changes to java.time serialization. The format of the serialized data is unchanged; deserialization uses readObject instead of readResolve to flag invalid values. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-time-serializatio

Re: RFR java.time serialization

2013-12-16 Thread Chris Hegarty
Roger, The source changes look good to me, and in line with the Serialization proxy idiom (ignoring the Externalizable stuff). -Chris. On 16 Dec 2013, at 17:02, roger riggs wrote: > Please review these changes to java.time serialization. > The format of the serialized data is unchanged; deser