Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-22 Thread Mikael Vidstedt
The makefile changes look good to me! Cheers, Mikael > On Jun 16, 2020, at 12:22 PM, Erik Joelsson wrote: > > (re-sending this as it doesn't look like it was delivered) > > There are a lot of jtreg tests that use temporary files. These temporary > files add up over time and fill up the glob

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Alan Bateman
On 17/06/2020 16:38, Erik Joelsson wrote: Ah, misunderstood you then. I added a comment to JDK-8213216 with more details and shortened the comment in the test: http://cr.openjdk.java.net/~erikj/8213214/webrev.03/ Looks okay as a workaround until we figure out what to do with subst. -Alan.

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Erik Joelsson
On 2020-06-17 07:43, Alan Bateman wrote: On 17/06/2020 14:47, Erik Joelsson wrote: I've tried to make this clearer in the comment. http://cr.openjdk.java.net/~erikj/8213214/webrev.02/ I would prefer if you could move the notes/comment from L125-157 to the bug report to avoid cluttering the

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Alan Bateman
On 17/06/2020 14:47, Erik Joelsson wrote: I've tried to make this clearer in the comment. http://cr.openjdk.java.net/~erikj/8213214/webrev.02/ I would prefer if you could move the notes/comment from L125-157 to the bug report to avoid cluttering the test. Instead, the test just needs a one l

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Erik Joelsson
On 2020-06-17 01:24, Alan Bateman wrote: On 16/06/2020 18:44, Erik Joelsson wrote: There are a lot of jtreg tests that use temporary files. These temporary files add up over time and fill up the global temp directories on our test systems. To tackle this, we should try to redirect these temp

Re: RFR: JDK-8213214: Set -Djava.io.tmpdir= when running tests

2020-06-17 Thread Alan Bateman
On 16/06/2020 18:44, Erik Joelsson wrote: There are a lot of jtreg tests that use temporary files. These temporary files add up over time and fill up the global temp directories on our test systems. To tackle this, we should try to redirect these temporary files into a directory controlled by t