Hi, Alan
Thanks. Pushed before saw your email, could not credit you on reviewers.
Thanks
Yumin
On 9/4/20 2:10 AM, Alan Bateman wrote:
On 04/09/2020 05:37, Yumin Qi wrote:
HI, Sundar
Thanks for review.
On 9/3/20 6:34 PM, sundararajan.athijegannat...@oracle.com wrote:
Looks good to me.
On 04/09/2020 05:37, Yumin Qi wrote:
HI, Sundar
Thanks for review.
On 9/3/20 6:34 PM, sundararajan.athijegannat...@oracle.com wrote:
Looks good to me.
Few minor comment:
* traceFileStream (and even the preexisting mainArgument) is accessed
only inside GenerateJLIClassesPlugin. Could be pr
HI, Sundar
Thanks for review.
On 9/3/20 6:34 PM, sundararajan.athijegannat...@oracle.com wrote:
Looks good to me.
Few minor comment:
* traceFileStream (and even the preexisting mainArgument) is accessed only
inside GenerateJLIClassesPlugin. Could be private?
I will fix them before push.
Looks good to me.
Few minor comment:
* traceFileStream (and even the preexisting mainArgument) is accessed
only inside GenerateJLIClassesPlugin. Could be private?
-Sundar
On 04/09/20 3:41 am, Yumin Qi wrote:
HI, Mandy
Thanks for review and comment.
Yumin
On 9/3/20 9:13 AM, Mandy Chung
HI, Mandy
Thanks for review and comment.
Yumin
On 9/3/20 9:13 AM, Mandy Chung wrote:
On 9/3/20 8:36 AM, Yumin Qi wrote:
Hi, Please review
bug: https://bugs.openjdk.java.net/browse/JDK-8252725
webrev: http://cr.openjdk.java.net/~minqi/2020/8252725/webrev-01/
Looks good to me. Sund
On 9/3/20 8:36 AM, Yumin Qi wrote:
Hi, Please review
bug: https://bugs.openjdk.java.net/browse/JDK-8252725
webrev: http://cr.openjdk.java.net/~minqi/2020/8252725/webrev-01/
Looks good to me. Sundar should also review it.
A few things to mention compared to the proposed patch from 8247
Sorry push "send" too soon:
Tests: local build. mach5 tier1-4 have 2 timeouts on build which I think
related to lab move(?).
Thanks
Yumin
On 9/3/20 8:36 AM, Yumin Qi wrote:
Hi, Please review
bug: https://bugs.openjdk.java.net/browse/JDK-8252725
webrev: http://cr.openjdk.java.net/~minqi/
