Re: RFR: 8248131: Simplify ServicesCatalog provider handling

2020-06-23 Thread Claes Redestad
Hi Alan, Mandy, thanks for reviewing. I've ran all java/lang/instrument and the com/sun/tools/attach/modules tests, as well as added tier2 to the testing mix. /Claes On 2020-06-23 16:09, Alan Bateman wrote: On 23/06/2020 09:56, Claes Redestad wrote: Hi, the current implementation of Service

Re: RFR: 8248131: Simplify ServicesCatalog provider handling

2020-06-23 Thread Mandy Chung
On 6/23/20 1:56 AM, Claes Redestad wrote: Hi, the current implementation of ServicesCatalog uses an internal providers method, which is only used to add ServiceProviders. Providing an addProviders method instead means we can streamline this, to the tune of a very small startup win. Bug:   

Re: RFR: 8248131: Simplify ServicesCatalog provider handling

2020-06-23 Thread Alan Bateman
On 23/06/2020 09:56, Claes Redestad wrote: Hi, the current implementation of ServicesCatalog uses an internal providers method, which is only used to add ServiceProviders. Providing an addProviders method instead means we can streamline this, to the tune of a very small startup win. Bug:    ht