Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-11 Thread Henry Jen
Thanks, it should be deliver. I'll fix before push it. Cheers, Henry On Sep 10, 2013, at 10:19 PM, Mike Duigou wrote: > Tests look fine. > > In the BiFunction test the unknown word "delieve" is used. I am not sure what > word was intended. > > Mike > > On Sep 10 2013, at 22:03 , Henry Jen

Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-11 Thread Henry Jen
Yes, the alignment is off, will fix. Cheers, Henry On Sep 11, 2013, at 7:36 AM, Alan Bateman wrote: > On 11/09/2013 06:03, Henry Jen wrote: >> Sorry I forgot it again. Copied but not pasted. :( >> >> http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/ >> >> Thanks for reviewing. >> >

Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-11 Thread Alan Bateman
On 11/09/2013 06:03, Henry Jen wrote: Sorry I forgot it again. Copied but not pasted. :( http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/ Thanks for reviewing. A minor comment but you might want to double check SingletonIterator.java as it looks a bit misaligned (might be tabs, migh

Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-10 Thread Mike Duigou
Tests look fine. In the BiFunction test the unknown word "delieve" is used. I am not sure what word was intended. Mike On Sep 10 2013, at 22:03 , Henry Jen wrote: > Sorry I forgot it again. Copied but not pasted. :( > > http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/ > > Thanks fo

Re: RFR: 8024500: Missing API coverage for java.util.function.BiFunction andThen

2013-09-10 Thread Henry Jen
Sorry I forgot it again. Copied but not pasted. :( http://cr.openjdk.java.net/~henryjen/tl/8024500/0/webrev/ Thanks for reviewing. Cheers, Henry On Sep 10, 2013, at 8:47 PM, Henry Jen wrote: > Hi, > > Please review a simple webrev that adds two tests, one for > > java.util.function.BiFuncti