Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-15 Thread Paul Sandoz
On Sep 10, 2013, at 4:34 PM, Alan Bateman wrote: > On 09/09/2013 14:35, Paul Sandoz wrote: >> On Sep 6, 2013, at 4:56 PM, Alan Bateman wrote: >> >>> : >>> The comments are very educational as the resizing is difficult to >>> completely grok without going through examples on a whiteboard. Anyw

Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-10 Thread Alan Bateman
On 09/09/2013 14:35, Paul Sandoz wrote: On Sep 6, 2013, at 4:56 PM, Alan Bateman wrote: : The comments are very educational as the resizing is difficult to completely grok without going through examples on a whiteboard. Anyway, I don't see anything obviously wrong after going through it. The

Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-09 Thread Paul Sandoz
On Sep 9, 2013, at 3:35 PM, Paul Sandoz wrote: > > On Sep 6, 2013, at 4:56 PM, Alan Bateman wrote: > >> On 06/09/2013 12:08, Paul Sandoz wrote: >>> On Sep 2, 2013, at 3:24 PM, Paul Sandoz wrote: >>> >>> : >>> Here is the fix in the lambda repo which can be applied to tl: ht

Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-09 Thread Paul Sandoz
On Sep 6, 2013, at 4:56 PM, Alan Bateman wrote: > On 06/09/2013 12:08, Paul Sandoz wrote: >> On Sep 2, 2013, at 3:24 PM, Paul Sandoz wrote: >> >> : >> >>> Here is the fix in the lambda repo which can be applied to tl: >>> >>> http://hg.openjdk.java.net/lambda/lambda/jdk/rev/b73937e96ae0 >>>

Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-06 Thread Remi Forax
On 09/06/2013 04:56 PM, Alan Bateman wrote: On 06/09/2013 12:08, Paul Sandoz wrote: On Sep 2, 2013, at 3:24 PM, Paul Sandoz wrote: : Here is the fix in the lambda repo which can be applied to tl: http://hg.openjdk.java.net/lambda/lambda/jdk/rev/b73937e96ae0 http://hg.openjdk.java.net/lambda

Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-06 Thread Alan Bateman
On 06/09/2013 12:08, Paul Sandoz wrote: On Sep 2, 2013, at 3:24 PM, Paul Sandoz wrote: : Here is the fix in the lambda repo which can be applied to tl: http://hg.openjdk.java.net/lambda/lambda/jdk/rev/b73937e96ae0 http://hg.openjdk.java.net/lambda/lambda/jdk/raw-rev/b73937e96ae0 Anyone

Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-06 Thread Chris Hegarty
On 06/09/2013 12:08, Paul Sandoz wrote: http://hg.openjdk.java.net/lambda/lambda/jdk/rev/b73937e96ae0 http://hg.openjdk.java.net/lambda/lambda/jdk/raw-rev/b73937e96ae0 Anyone up for reviewing this? I skimmed the patch and nothing jumps out at me. There does appear to be some code

Re: RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-06 Thread Paul Sandoz
On Sep 2, 2013, at 3:24 PM, Paul Sandoz wrote: > > On Sep 2, 2013, at 1:18 PM, Doug Lea wrote: > >> On 08/28/2013 09:13 AM, Peter Levart wrote: >>> On 08/28/2013 12:10 PM, Paul Sandoz wrote: Hi, Intermittent failures were reported with the CHM toArray test in the JDK. >>

RFR 8010293 Re: Potential issue with CHM.toArray

2013-09-02 Thread Paul Sandoz
On Sep 2, 2013, at 1:18 PM, Doug Lea wrote: > On 08/28/2013 09:13 AM, Peter Levart wrote: >> On 08/28/2013 12:10 PM, Paul Sandoz wrote: >>> Hi, >>> >>> Intermittent failures were reported with the CHM toArray test in the JDK. >>> >>> I updated the tests to increase the number of runs and the n

Re: Potential issue with CHM.toArray

2013-09-02 Thread Doug Lea
On 08/28/2013 09:13 AM, Peter Levart wrote: On 08/28/2013 12:10 PM, Paul Sandoz wrote: Hi, Intermittent failures were reported with the CHM toArray test in the JDK. I updated the tests to increase the number of runs and the number of workers and i can reliably reproduce on my laptop, see below

Re: Potential issue with CHM.toArray

2013-08-30 Thread Paul Sandoz
On Aug 29, 2013, at 1:44 PM, Doug Lea wrote: > On 08/28/2013 09:13 AM, Peter Levart wrote: > >> It seems that the iteration can traverse through the same tables multiple >> times >> (back and forth) by following ForwardingNode.nextTable links. Aren't >> nextTable >> links supposed to be only

Re: Potential issue with CHM.toArray

2013-08-29 Thread Doug Lea
On 08/28/2013 09:13 AM, Peter Levart wrote: It seems that the iteration can traverse through the same tables multiple times (back and forth) by following ForwardingNode.nextTable links. Aren't nextTable links supposed to be only in "forward" direction, leading to from smaller to larger tables?

Re: Potential issue with CHM.toArray

2013-08-28 Thread Peter Levart
On 08/28/2013 12:10 PM, Paul Sandoz wrote: Hi, Intermittent failures were reported with the CHM toArray test in the JDK. I updated the tests to increase the number of runs and the number of workers and i can reliably reproduce on my laptop, see below. The test presumes the size should always

Re: Potential issue with CHM.toArray

2013-08-28 Thread Doug Lea
On 08/28/2013 06:10 AM, Paul Sandoz wrote: Hi, Intermittent failures were reported with the CHM toArray test in the JDK. I updated the tests to increase the number of runs and the number of workers and i can reliably reproduce on my laptop, see below. The test presumes the size should always