Hi Lance,
- logSync is not declared final.
- the comment "thow a SecurityException" is not that useful
- in getDrivers(), I think you can use an ArrayList to gather
all drivers and use Collections.enumeration() at the end.
- also instead of
if (drivers == null || drivers.equals("
Hi Dave,
Yes it could be made final. This is just a hold over from the original code,
but there is no reason that I cannot make it final.
Regards
Lance
On Mar 11, 2011, at 6:26 PM, David Schlosnagle wrote:
> On Fri, Mar 11, 2011 at 3:03 PM, Lance Andersen - Oracle
> wrote:
>> I have posted th
On Fri, Mar 11, 2011 at 3:03 PM, Lance Andersen - Oracle
wrote:
> I have posted the diffs to DriverManager for review at
> http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes
> CopyOnWriteArrayList instead of the Vectors previously used.
Lance,
Shouldn't the logSync lock field b
Hi Ulf,
Thank you for the note.
On Mar 11, 2011, at 3:18 PM, Ulf Zibis wrote:
> Maybe you could update the javadoc style ( -> @code etc.) and move the
> constructor to the begining.
I need to go through all of the java.sql & javax.sql classes to address HTML
issues over the coming weeks, I
Maybe you could update the javadoc style ( -> @code etc.) and move the constructor to the
begining.
-Ulf
Am 11.03.2011 21:03, schrieb Lance Andersen - Oracle:
Hi,
I have posted the diffs to DriverManager for review at
http://cr.openjdk.java.net/~lancea/7026898/. This change utilizes
CopyO
