Re: 8067801: Enforce null check for underlying I/O streams

> On Jul 18, 2019, at 8:55 AM, Brian Burkhalter > wrote: > >> I see this is has pushed but I think it will need to be re-examined because >> the javadoc allows `in` and `out` to be specified as null and set after the >> stream is created (the javadoc for the parameters overrides the "Unless

Re: 8067801: Enforce null check for underlying I/O streams

> On Jul 18, 2019, at 8:52 AM, Alan Bateman wrote: > > On 17/07/2019 17:12, Brian Burkhalter wrote: >> https://bugs.openjdk.java.net/browse/JDK-8067801 >> >> http://cr.openjdk.java.net/~bpb/8067801/webrev.00/ >>

Re: 8067801: Enforce null check for underlying I/O streams

On 17/07/2019 17:12, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8067801 http://cr.openjdk.java.net/~bpb/8067801/webrev.00/ Add null check to Filter{In,Out}putStream constructors. This covers all the cases listed in the issue as those are all subclasses of these two classes

Re: 8067801: Enforce null check for underlying I/O streams

Thanks, Lance! > On Jul 17, 2019, at 2:19 PM, Lance Andersen wrote: > > Looks good. Maybe consider expanding to some of the other classes when you > have cycles. But in the meantime, ship it!

Re: 8067801: Enforce null check for underlying I/O streams

Hi Brian > On Jul 17, 2019, at 5:08 PM, Brian Burkhalter > wrote: > > Hi Lance, > >> On Jul 17, 2019, at 1:55 PM, Lance Andersen > > wrote: >> >> I guess the next question(here he goes again ;-) is do you want to test all >> of the constructors such as Buffe

Re: 8067801: Enforce null check for underlying I/O streams

Hi Lance, > On Jul 17, 2019, at 1:55 PM, Lance Andersen wrote: > > I guess the next question(here he goes again ;-) is do you want to test all > of the constructors such as BufferedInputStream(InputStream, int) or just one > per class? I realize the BufferedInputStream(InputStream) just call

Re: 8067801: Enforce null check for underlying I/O streams

Hi Brian > On Jul 17, 2019, at 4:39 PM, Brian Burkhalter > wrote: > > Hi Lance, > >> On Jul 17, 2019, at 1:02 PM, Lance Andersen > > wrote: >> >> I think what you have is fine, a unique test in each subdirectory as it is >> organized by class. What you might

Re: 8067801: Enforce null check for underlying I/O streams

Hi Lance, > On Jul 17, 2019, at 1:02 PM, Lance Andersen wrote: > > I think what you have is fine, a unique test in each subdirectory as it is > organized by class. What you might consider is having a generic NPE Test > class, which validates the error for Constructors and methods as described

Re: 8067801: Enforce null check for underlying I/O streams

Hi Brian, > On Jul 17, 2019, at 3:46 PM, Brian Burkhalter > wrote: > > Hi Lance, > >> On Jul 17, 2019, at 12:35 PM, Brian Burkhalter > > wrote: >> >>> I might consider adding the NPE message to the individual classes as it is >>> easy to miss in the java.io

Re: 8067801: Enforce null check for underlying I/O streams

Hi Lance, > On Jul 17, 2019, at 12:35 PM, Brian Burkhalter > wrote: > >> I might consider adding the NPE message to the individual classes as it is >> easy to miss in the java.io > > package but that is just a suggestion. Especially with

Re: 8067801: Enforce null check for underlying I/O streams

Hi Lance, > On Jul 17, 2019, at 12:28 PM, Lance Andersen > wrote: > > I think this looks good. Thanks. > I might consider adding the NPE message to the individual classes as it is > easy to miss in the java.io package but that is just a > suggestion. Especially with the

Re: 8067801: Enforce null check for underlying I/O streams

Hi Brian, I think this looks good. I might consider adding the NPE message to the individual classes as it is easy to miss in the java.io package but that is just a suggestion. Especially with the new search feature of javadoc, I usually go straight to the method so would never see the info