Re: RFR of JDK-8176721: @since value errors java.sql module

Hi Lance, Thank you for reviewing, I agree with you, and will adjust the tool's algorithm to take this into account. I just reverted the changes for xxxDataSource for the getXXX/setXXX methods, and pushed the code. Thank you -Hamlin On 2017/3/14 20:43, Lance Andersen wrote: Hi Hamlin,

Re: RFR of JDK-8176721: @since value errors java.sql module

Hi Hamlin, Everything with the exception of the xxxDataSource changes are correct. Best Lance > On Mar 14, 2017, at 7:05 AM, Lance Andersen wrote: > > Hi Hamlin, > > The changes for xxxDataSource for the getXXX/setXXX methods which you marked > as @since 9 is not correct. The common method

Re: RFR of JDK-8176721: @since value errors java.sql module

Hi Hamlin, The changes for xxxDataSource for the getXXX/setXXX methods which you marked as @since 9 is not correct. The common methods were placed in CommonDataSource in JDBC 4/JDK 1.6 to make it easier for updates. Please see https://bugs.openjdk.java.net/browse/JDK-8164061

RFR of JDK-8176721: @since value errors java.sql module

Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176721 webrev: http://cr.openjdk.java.net/~mli/8176721/webrev.00/ Thank you -Hamlin