Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-26 Thread Abhijit Roy
Hi Roger, Could you please push it for 9ea? If so, please find the attached changeset files. Regards Abhijit On 12/21/2016 7:53 PM, Roger Riggs wrote: Hi Abhijit, Looks fine to push with this additional change to make the descriptions of 'F' match. Thanks, Roger On 12/21/16 7:16 AM, Iv

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-22 Thread Abhijit Roy
Hi Roger, Ivan, Already done. Please see the JDK below. https://bugs.openjdk.java.net/browse/JDK-8169482 Thanks Abhijit On 12/21/2016 7:53 PM, Roger Riggs wrote: Hi Abhijit, Looks fine to push with this additional change to make the descriptions of 'F' match. Thanks, Roger On 12/21/16

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-21 Thread Roger Riggs
Hi Abhijit, Looks fine to push with this additional change to make the descriptions of 'F' match. Thanks, Roger On 12/21/16 7:16 AM, Ivan Gerasimov wrote: Hi Abhijt! As you're changing the description of 'F' pattern in DateTimeFormatterBuilder, it makes sense to do the same in DateTimeFo

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-21 Thread Ivan Gerasimov
Hi Abhijt! As you're changing the description of 'F' pattern in DateTimeFormatterBuilder, it makes sense to do the same in DateTimeFormatter. With kind regards, Ivan On 21.12.2016 9:30, Abhijit Roy wrote: Hi Roger, I have fixed the same error in DateTimeFormatterBuiler. Please see the up

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-21 Thread Stephen Colebourne
Looks good Stephen On 21 Dec 2016 6:31 a.m., "Abhijit Roy" wrote: Hi Roger, I have fixed the same error in DateTimeFormatterBuiler. Please see the updated webrev below. Webrev: http://cr.openjdk.java.net/~rpatil/8171348/webrev.01/ Thanks Abhijit On 12/16/2016 8:01 PM, Roger Riggs wrote:

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-20 Thread Abhijit Roy
Hi Roger, I have fixed the same error in DateTimeFormatterBuiler. Please see the updated webrev below. Webrev: http://cr.openjdk.java.net/~rpatil/8171348/webrev.01/ Thanks Abhijit On 12/16/2016 8:01 PM, Roger Riggs wrote: Hi, Sorry, I meant DateTimeFormatterBuilder. Roger On 12/16/2016

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-16 Thread Roger Riggs
Hi, Sorry, I meant DateTimeFormatterBuilder. Roger On 12/16/2016 9:28 AM, Roger Riggs wrote: Hi Abhijit, Please also fix the same error in DateTimeFormatter; line 300. I would use '24' as the example of the hour of day. It would emphasize that the range is 1-24. Roger On 12/16/2016 6:19

Re: RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-16 Thread Roger Riggs
Hi Abhijit, Please also fix the same error in DateTimeFormatter; line 300. I would use '24' as the example of the hour of day. It would emphasize that the range is 1-24. Roger On 12/16/2016 6:19 AM, Abhijit Roy wrote: Hi all, Please review the java doc fix for the below bug: Bug: http

RFR JDK-8171348: Incorrect documentation for DateTimeFormatter letter 'k'

2016-12-16 Thread Abhijit Roy
Hi all, Please review the java doc fix for the below bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8171348 Description: Incorrect documentation for DateTimeFormatter letter 'k' Webrev: http://cr.openjdk.java.net/~rpatil/8171348/webrev.00/ I have just rectified and modified those err