Re: RFR JDK-8149769: Null pointer exception in ZipFileSystemProvider

2016-02-12 Thread Steve Drach
> What's the issue? The bug description only includes the fix. If the env is > null, shouldn't > it trigger a NPE? > > The java.nio.file.spi package does have the note that "NPE, unless otherwise > noted ..." > The api for FilesystemProvider.newFileSystem(..., env) says "env" can be > empty, me

Re: RFR JDK-8149769: Null pointer exception in ZipFileSystemProvider

2016-02-12 Thread Xueming Shen
Steve, What's the issue? The bug description only includes the fix. If the env is null, shouldn't it trigger a NPE? The java.nio.file.spi package does have the note that "NPE, unless otherwise noted ..." The api for FilesystemProvider.newFileSystem(..., env) says "env" can be empty, means N

Re: RFR JDK-8149769: Null pointer exception in ZipFileSystemProvider

2016-02-12 Thread Steve Drach
>> Please review this simple fix to ZipFileSystemProvider. The issue is >> JDK-8149769 . I didn’t do >> a webrev but instead provide the following patch. >> >> > This looks okay. Can one of the existing tests be updated to cover this case? Ye

Re: RFR JDK-8149769: Null pointer exception in ZipFileSystemProvider

2016-02-12 Thread Alan Bateman
On 12/02/2016 21:11, Steve Drach wrote: Hi, Please review this simple fix to ZipFileSystemProvider. The issue is JDK-8149769 . I didn’t do a webrev but instead provide the following patch. This looks okay. Can one of the existing tests be

Re: RFR JDK-8149769: Null pointer exception in ZipFileSystemProvider

2016-02-12 Thread Roger Riggs
Look fine. Roger On 2/12/16 4:11 PM, Steve Drach wrote: Hi, Please review this simple fix to ZipFileSystemProvider. The issue is JDK-8149769 . I didn’t do a webrev but instead provide the following patch. Thanks Steve diff -r 2d6c2c75f33

RFR JDK-8149769: Null pointer exception in ZipFileSystemProvider

2016-02-12 Thread Steve Drach
Hi, Please review this simple fix to ZipFileSystemProvider. The issue is JDK-8149769 . I didn’t do a webrev but instead provide the following patch. Thanks Steve diff -r 2d6c2c75f338 src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystemPro