Re: RFR 8252538: Replace @exception with @throws java.rmi package

> On 3 Sep 2020, at 18:51, Vipin Sharma wrote: > > I agree. In the next patch, I will include all remaining occurrences of > @exception in the core-libs > area. > > Also, I noticed that those files still use the markup. >> Converting them to use {@c

Re: RFR 8252538: Replace @exception with @throws java.rmi package

Hi Roger, On Thu, Sep 3, 2020 at 2:20 AM Roger Riggs wrote: > Hi Vipin, > > Looks fine. > > I see you filed separate tasks for the other packages in java.rmi. [1] > That's unnecessarily fine grained. > It would be more efficient to do them all in one code review, saving your > time and reviewers

Re: RFR 8252538: Replace @exception with @throws java.rmi package

Hi Vipin, Looks fine. I see you filed separate tasks for the other packages in java.rmi. [1] That's unnecessarily fine grained. It would be more efficient to do them all in one code review, saving your time and reviewers time. Also, I noticed that those files still use the markup. Convertin

Re: RFR 8252538: Replace @exception with @throws java.rmi package

Hi Roger, On Tue, Sep 1, 2020 at 10:49 PM Roger Riggs wrote: > Hi Vipin, > > Looks fine. > > Though I would also correct the indentation and join source lines in a > few cases. > > MasrshalledObject.java. Continuation lines should be indented. Lines > 110 and 164, 166. > Fixed. > > Naming.java

Re: RFR 8252538: Replace @exception with @throws java.rmi package

Hi Vipin, Looks fine. Though I would also correct the indentation and join source lines in a few cases. MasrshalledObject.java.  Continuation lines should be indented. Lines 110 and 164, 166. Naming.java: Join line 110, 137, 162, 191: "appropriately... formatted URL" Thanks, Roger Hi,

RFR 8252538: Replace @exception with @throws java.rmi package

Hi, Please review and sponsor the fix for replacing @exception with @throws in java.rmi package. Issue: https://bugs.openjdk.java.net/browse/JDK-8252538 Webrev: https://cr.openjdk.java.net/~vsharma/8252538/webrev.01/ Regards, Vipin