Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-28 Thread Thomas Stüfe
Looks good to me. Thanks for checking. Cheers, Thomas On Fri, Aug 28, 2020 at 1:25 PM Alexander Scherbatiy < alexander.scherba...@bell-sw.com> wrote: > Hello, > > Could you review the updated fix: >http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/ > > - moving shared code to net_util_

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-28 Thread Vyom Tiwari
+1 Vyom On Fri, Aug 28, 2020 at 8:24 PM Alexander Scherbatiy < alexander.scherba...@bell-sw.com> wrote: > On 28.08.2020 17:40, Alan Bateman wrote: > > > On 28/08/2020 15:32, Alexander Scherbatiy wrote: > >> > >> I run the java/nio/channels tests with the fix. There are five > >> failed tests th

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-28 Thread Alexander Scherbatiy
On 28.08.2020 17:40, Alan Bateman wrote: On 28/08/2020 15:32, Alexander Scherbatiy wrote:   I run the java/nio/channels tests with the fix. There are five failed tests that fail with and without the fix:     java/nio/channels/DatagramChannel/AdaptorMulticasting.java java/nio/channels/Datagra

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-28 Thread Alan Bateman
On 28/08/2020 15:32, Alexander Scherbatiy wrote:   I run the java/nio/channels tests with the fix. There are five failed tests that fail with and without the fix:     java/nio/channels/DatagramChannel/AdaptorMulticasting.java java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java    

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-28 Thread Alexander Scherbatiy
On 28.08.2020 15:55, Alan Bateman wrote: On 28/08/2020 12:25, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/  - moving shared code to net_util_md.h is avoided  - INTERRUPT_SIGNAL is defined as SIGRTMAX - 2 instead

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-28 Thread Alan Bateman
On 28/08/2020 12:25, Alexander Scherbatiy wrote: Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/  - moving shared code to net_util_md.h is avoided  - INTERRUPT_SIGNAL is defined as SIGRTMAX - 2 instead of __SIGRTMAX - 2 for Linux in NativeThrea

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-28 Thread Alexander Scherbatiy
Hello, Could you review the updated fix:   http://cr.openjdk.java.net/~alexsch/8252248/webrev.01/  - moving shared code to net_util_md.h is avoided  - INTERRUPT_SIGNAL is defined as SIGRTMAX - 2 instead of __SIGRTMAX - 2 for Linux in NativeThread.c  - "#include " is moved out from "#ifdef" in

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-26 Thread Thomas Stüfe
Hi Alexander, --- src/java.base/unix/native/libnet/net_util_md.h why include pthread.h? SIGRTMAX is in signal.h on posix ( https://pubs.opengroup.org/onlinepubs/007908799/xsh/signal.h.html). I see the old code included this too, pretty sure this was either incidental or just wrong. --- Are the

Re: RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-26 Thread Alan Bateman
On 25/08/2020 18:00, Alexander Scherbatiy wrote: Hello, Could your review the fix for the issue:   Bug: https://bugs.openjdk.java.net/browse/JDK-8252248   Fix: http://cr.openjdk.java.net/~alexsch/8252248/webrev.00/ : The fix has been discussed on the portola-dev alias [2] where it was pointe

RFR 8252248: __SIGRTMAX is not declared in musl libc

2020-08-25 Thread Alexander Scherbatiy
Hello, Could your review the fix for the issue:   Bug: https://bugs.openjdk.java.net/browse/JDK-8252248   Fix: http://cr.openjdk.java.net/~alexsch/8252248/webrev.00/ Building JDK on Alpine Linux with musl libc gives the error: src/java.base/linux/native/libnet/linux_close.c:63:25: error: '__S