Re: RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

2018-12-04 Thread Brian Burkhalter
Hi Roger, > On Dec 4, 2018, at 8:58 AM, Roger Riggs wrote: > > Thanks for the reviews. You’re welcome. > I simplify the description, the full details are in the bug report > and are more complete. > > Updated webrev: > http://cr.openjdk.java.net/~rriggs/webrev-basic-8171426-1/ >

Re: RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

2018-12-04 Thread James Laskey
I wasn’t as fussy about the original comment but this one is also fine. Sent from my iPhone > On Dec 4, 2018, at 12:58 PM, Roger Riggs wrote: > > Hi Brian, Jim, > > Thanks for the reviews. > > I simplify the description, the full details are in the bug report > and are more complete. > > Up

Re: RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

2018-12-04 Thread Roger Riggs
Hi Brian, Jim, Thanks for the reviews. I simplify the description, the full details are in the bug report and are more complete. Updated webrev:   http://cr.openjdk.java.net/~rriggs/webrev-basic-8171426-1/ Thanks, Roger On 12/03/2018 04:49 PM, Brian Burkhalter wrote: Hi Roger, L2:copyright

Re: RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

2018-12-04 Thread Jim Laskey
+1 > On Dec 3, 2018, at 5:45 PM, Roger Riggs wrote: > > Ping? > > On 11/27/2018 02:04 PM, Roger Riggs wrote: >> Please review a test update to address an intermittent test failure. >> The test is modified to accept the current implementation behavior of the >> input streams >> from processes t

Re: RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

2018-12-03 Thread Brian Burkhalter
Hi Roger, L2: copyright year, of course L2119: The verbiage seems a little obtuse. Otherwise, +1. Thanks, Brian On 11/27/2018 02:04 PM, Roger Riggs wrote: > Please review a test update to address an intermittent test failure. > The test is modified to accept the current implementation beha

Re: RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

2018-12-03 Thread Roger Riggs
Ping? On 11/27/2018 02:04 PM, Roger Riggs wrote: Please review a test update to address an intermittent test failure. The test is modified to accept the current implementation behavior of the input streams from processes that may under race conditions with close throw IOE("Stream closed"). D

RFR 8171426 : java/lang/ProcessBuilder/Basic.java failed with Stream closed

2018-11-27 Thread Roger Riggs
Please review a test update to address an intermittent test failure. The test is modified to accept the current implementation behavior of the input streams from processes that may under race conditions with close throw IOE("Stream closed"). Details and analysis in the Jira:   https://bugs.ope