Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-02 Thread Mandy Chung
I wasn't aware of the VM special case of System.{in,out,err} fields that Doug pointed out (thanks. I should have checked). That's okay with me. Mandy On 7/2/2014 10:05 AM, Coleen Phillimore wrote: Hi Mandy, The componentType field is the last one that I'm planning on moving out for now, s

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-02 Thread Coleen Phillimore
Hi Mandy, The componentType field is the last one that I'm planning on moving out for now, so I'd like to keep the code as is. If more are added because of more performance opportunities, I think we can revisit this. I agree with Doug that we don't want any more special code like this in t

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-02 Thread Coleen Phillimore
On 7/2/14, 8:41 AM, Peter Levart wrote: On 07/02/2014 02:38 PM, Peter Levart wrote: On 07/02/2014 02:22 PM, Peter Levart wrote: On 07/02/2014 08:26 AM, Mandy Chung wrote: On 6/30/2014 9:51 PM, Christian Thalinger wrote: On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: On 6/30/14, 3

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-02 Thread Peter Levart
On 07/02/2014 02:38 PM, Peter Levart wrote: On 07/02/2014 02:22 PM, Peter Levart wrote: On 07/02/2014 08:26 AM, Mandy Chung wrote: On 6/30/2014 9:51 PM, Christian Thalinger wrote: On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote:

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-02 Thread Peter Levart
On 07/02/2014 02:22 PM, Peter Levart wrote: On 07/02/2014 08:26 AM, Mandy Chung wrote: On 6/30/2014 9:51 PM, Christian Thalinger wrote: On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) {

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-02 Thread Peter Levart
On 07/02/2014 08:26 AM, Mandy Chung wrote: On 6/30/2014 9:51 PM, Christian Thalinger wrote: On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader.

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-01 Thread Mandy Chung
On 6/30/2014 9:51 PM, Christian Thalinger wrote: On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-07-01 Thread Coleen Phillimore
Thank you! Coleen On 7/1/14, 12:51 AM, Christian Thalinger wrote: On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Christian Thalinger
On Jun 30, 2014, at 5:50 PM, Coleen Phillimore wrote: > > On 6/30/14, 3:50 PM, Christian Thalinger wrote: >> private Class(ClassLoader loader) { >> // Initialize final field for classLoader. The initialization >> value of non-null >> // prevents future JIT optimization

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Coleen Phillimore
On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents future JIT optimizations from assuming this final field is null. classLoader = lo

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Christian Thalinger
On Jun 30, 2014, at 1:06 PM, Coleen Phillimore wrote: > > On 6/30/14, 3:50 PM, Christian Thalinger wrote: >> private Class(ClassLoader loader) { >> // Initialize final field for classLoader. The initialization >> value of non-null >> // prevents future JIT optimization

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Coleen Phillimore
On 6/30/14, 3:50 PM, Christian Thalinger wrote: private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents future JIT optimizations from assuming this final field is null. classLoader = lo

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Christian Thalinger
private Class(ClassLoader loader) { // Initialize final field for classLoader. The initialization value of non-null // prevents future JIT optimizations from assuming this final field is null. classLoader = loader; +componentType = null; } Are we wor

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Coleen Phillimore
Thank you, Fred, and thanks for correcting the link below. Coleen On 6/30/14, 10:27 AM, Frederic Parain wrote: On 30/06/2014 14:42, Coleen Phillimore wrote: On 6/30/14, 1:55 AM, David Holmes wrote: Hi Coleen, Your webrev links are to internal locations. Sorry, I cut/pasted the wrong lin

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Frederic Parain
On 30/06/2014 14:42, Coleen Phillimore wrote: On 6/30/14, 1:55 AM, David Holmes wrote: Hi Coleen, Your webrev links are to internal locations. Sorry, I cut/pasted the wrong links. They are: http://cr.openjdk.java.net/~coleenp/8047737_jdk/ http://cr.openjdk.java.net/~coleenp/8047737_hotsp

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-30 Thread Coleen Phillimore
On 6/30/14, 1:55 AM, David Holmes wrote: Hi Coleen, Your webrev links are to internal locations. Sorry, I cut/pasted the wrong links. They are: http://cr.openjdk.java.net/~coleenp/8047737_jdk/ http://cr.openjdk.java.net/~coleenp/8047737_hotspot/ and the full version http://cr.openjdk.java

Re: RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-29 Thread David Holmes
Hi Coleen, Your webrev links are to internal locations. David On 28/06/2014 5:24 AM, Coleen Phillimore wrote: Summary: Add field in java.lang.Class for componentType to simplify oop processing and intrinsics in JVM This is part of ongoing work to clean up oop pointers in the metadata and simp

RFR 8047737 Move array component mirror to instance of java/lang/Class

2014-06-27 Thread Coleen Phillimore
Summary: Add field in java.lang.Class for componentType to simplify oop processing and intrinsics in JVM This is part of ongoing work to clean up oop pointers in the metadata and simplify the interface between the JDK j.l.C and the JVM. There's a performance benefit at the end of all of this