Re: RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread Paul Sandoz
> On 16 Mar 2017, at 14:33, mark.reinh...@oracle.com wrote: > > 2017/3/16 14:31:21 -0700, pavel.ra...@oracle.com: >> Exactly: >> >> * >> * This is a value-based >> * class; use of identity-sensitive operations (including reference equality >> * ({@code ==}), identity hash code, or synchronizatio

Re: RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread mark . reinhold
2017/3/16 14:31:21 -0700, pavel.ra...@oracle.com: > Exactly: > > * > * This is a value-based > * class; use of identity-sensitive operations (including reference equality > * ({@code ==}), identity hash code, or synchronization) on instances of > * {@code Optional} may have unpredictable results a

Re: RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread Pavel Rappo
Exactly: * * This is a value-based * class; use of identity-sensitive operations (including reference equality * ({@code ==}), identity hash code, or synchronization) on instances of * {@code Optional} may have unpredictable results and should be avoided. * > On 16 Mar 2017, at 20:41, Paul Sando

Re: RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread Paul Sandoz
> On 16 Mar 2017, at 13:27, Pavel Rappo wrote: > > Paul, > > One more question. I have read Version's javadoc and my impression is that > Version could be a value-type class. Is that right? > I suppose it could if there were such a thing as of today. It's not explicitly called out as being v

Re: RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread Pavel Rappo
Paul, One more question. I have read Version's javadoc and my impression is that Version could be a value-type class. Is that right? > On 16 Mar 2017, at 18:05, Paul Sandoz wrote: > >> >> On 16 Mar 2017, at 08:27, mark.reinh...@oracle.com wrote: >> >> 2017/3/16 8:17:03 -0700, pavel.ra...@ora

Re: RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread Paul Sandoz
> On 16 Mar 2017, at 08:27, mark.reinh...@oracle.com wrote: > > 2017/3/16 8:17:03 -0700, pavel.ra...@oracle.com: >> Please review the following trivial change for [1]: >> >> http://cr.openjdk.java.net/~prappo/8160956/webrev.00/ > > Looks good to me. > >> ... >> >> P.S. While we are in this a

Re: RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread mark . reinhold
2017/3/16 8:17:03 -0700, pavel.ra...@oracle.com: > Please review the following trivial change for [1]: > > http://cr.openjdk.java.net/~prappo/8160956/webrev.00/ Looks good to me. > ... > > P.S. While we are in this area, may I ask if anybody knows why exactly Version > class has lost its 'fin

RFR[9] 8160956: Runtime.Version.compareTo/compareToIgnoreOpt problem

2017-03-16 Thread Pavel Rappo
Hello, Please review the following trivial change for [1]: http://cr.openjdk.java.net/~prappo/8160956/webrev.00/ The code change fixes the implementation and makes it adhere to the specification for Version comparison: /** * Compares this version to another. * ... *