Extra points would be to substitute the resulting snippet for the actual
implementation to see if it compiles and satisfies the tests. For example, like
this:
default boolean replace(K key, V oldValue, V newValue) {
Map map = this; // synthetic line
if (map.containsKey(key) && Objects.
Looks good to me
On Fri, Jun 5, 2020 at 8:20 AM Conor Cleary wrote:
>
> Hi,
>
> Could someone please take a look at my webrev for JDK-8243655
> 'Map.replace javadoc code snippet typo'?
>
> This fix addresses a typo in the javadoc for Map.replace(K, V, V) in the
> default implementation code. The
+1
> On Jun 5, 2020, at 12:20 PM, Conor Cleary wrote:
>
> Hi,
>
> Could someone please take a look at my webrev for JDK-8243655 'Map.replace
> javadoc code snippet typo'?
>
> This fix addresses a typo in the javadoc for Map.replace(K, V, V) in the
> default implementation code. The parameter
Hi,
Could someone please take a look at my webrev for JDK-8243655
'Map.replace javadoc code snippet typo'?
This fix addresses a typo in the javadoc for Map.replace(K, V, V) in the
default implementation code. The parameter 'value' in the conditional
block is changed to 'oldValue' to reflect
