Re: RFR: minor doc fixes for java.util.Formatter

2013-10-25 Thread Stuart Marks
Ha! Some quick and easy reviews for a Friday afternoon! OK, I'll pop this one in. Thanks. s'marks On 10/25/13 2:02 PM, Lance Andersen - Oracle wrote: +1 On Oct 25, 2013, at 4:50 PM, Stuart Marks wrote: Hi all, Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs ar

Re: RFR: minor doc fixes for java.util.Formatter

2013-10-25 Thread Chris Hegarty
Looks fine to me. The example "%1$tm %1$te,%1$tY" is used elsewhere in the class description, but I think your change is probably best ( rather than trying to make them consistent ). -Chris. On 10/25/2013 09:50 PM, Stuart Marks wrote: Hi all, Please review a few minor javadoc fixes in java

Re: RFR: minor doc fixes for java.util.Formatter

2013-10-25 Thread Lance Andersen - Oracle
+1 On Oct 25, 2013, at 4:50 PM, Stuart Marks wrote: > Hi all, > > Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs > are: > > https://bugs.openjdk.java.net/browse/JDK-5063500 > https://bugs.openjdk.java.net/browse/JDK-7126305 > https://bugs.openjdk.java.net/browse/J

Re: RFR: minor doc fixes for java.util.Formatter

2013-10-25 Thread Joe Darcy
Looks good! -Joe On 10/25/2013 01:50 PM, Stuart Marks wrote: Hi all, Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs are: https://bugs.openjdk.java.net/browse/JDK-5063500 https://bugs.openjdk.java.net/browse/JDK-7126305 https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: minor doc fixes for java.util.Formatter

2013-10-25 Thread roger riggs
Three for the price of one. Looks fine. (Not a Reviewer) Roger On 10/25/2013 4:50 PM, Stuart Marks wrote: Hi all, Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs are: https://bugs.openjdk.java.net/browse/JDK-5063500 https://bugs.openjdk.java.net/browse/JDK-71

RFR: minor doc fixes for java.util.Formatter

2013-10-25 Thread Stuart Marks
Hi all, Please review a few minor javadoc fixes in java.util.Formatter. Links to bugs are: https://bugs.openjdk.java.net/browse/JDK-5063500 https://bugs.openjdk.java.net/browse/JDK-7126305 https://bugs.openjdk.java.net/browse/JDK-8027287 The fixes are all one-liners so I've just appended the p