Re: RFR: jsr166 jdk9 integration wave 10

2016-09-12 Thread Aleksey Shipilev
On 09/12/2016 07:57 PM, Martin Buchholz wrote: > is better spelled like this? > > 176 * setPendingCount(1); // only one pending, not two! > > I already struggled over the wording here hmmm ... how about > > // looks off by one, but correct! Yes, this is better. > I don't

Re: RFR: jsr166 jdk9 integration wave 10

2016-09-12 Thread Paul Sandoz
> On 12 Sep 2016, at 09:57, Martin Buchholz wrote: > > > > On Mon, Sep 12, 2016 at 3:22 AM, Aleksey Shipilev > wrote: > > Minor things: > > CountedCompleter.java: > > 176 * setPendingCount(1); // not off by one ! > > is better spelled like this? > > 17

Re: RFR: jsr166 jdk9 integration wave 10

2016-09-12 Thread Martin Buchholz
On Mon, Sep 12, 2016 at 3:22 AM, Aleksey Shipilev wrote: > > Minor things: > > CountedCompleter.java: > > 176 * setPendingCount(1); // not off by one ! > > is better spelled like this? > > 176 * setPendingCount(1); // only one pending, not two! > I already struggled over the

Re: RFR: jsr166 jdk9 integration wave 10

2016-09-12 Thread Paul Sandoz
> On 10 Sep 2016, at 10:21, Martin Buchholz wrote: > > > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ > +1 CountedCompleter — 176 * setPendingCount(1); // not off by one ! CountedCompleterTest — 1910 setPendingCount(1); // not

Re: RFR: jsr166 jdk9 integration wave 10

2016-09-12 Thread Aleksey Shipilev
On 09/10/2016 08:21 PM, Martin Buchholz wrote: > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ > > Mostly docs and tests. Looks good. Very nice use of (frequently overlooked) local classes in examples. Minor things: CountedCompleter.java: 176 * setPendi

RFR: jsr166 jdk9 integration wave 10

2016-09-10 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ Mostly docs and tests. jsr166 CVS is now caught up with jdk9+135 Paul, I think we need to update AtomicInteger for VarHandle#getAndAdd: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/miscel