Re: RFR: jsr166 jdk10 integration wave 1

2017-07-22 Thread Martin Buchholz
Finally submitted. On Tue, Jul 18, 2017 at 9:35 AM, Martin Buchholz wrote: > After a long delay, we are finally ready to try again to get in jsr166 > jdk10 integration wave 1. > > The set of changes has grown a lot over the past few months (too much?), > and contains the usual hard-to-review tck

Re: RFR: jsr166 jdk10 integration wave 1

2017-07-18 Thread Martin Buchholz
After a long delay, we are finally ready to try again to get in jsr166 jdk10 integration wave 1. The set of changes has grown a lot over the past few months (too much?), and contains the usual hard-to-review tck test improvements. Our infrastructure for generating these commits has changed a lot

Re: RFR: jsr166 jdk10 integration wave 1

2017-04-10 Thread Martin Buchholz
Non-thread-pool changes committed while we wait for thread-pool CCC.

Re: RFR: jsr166 jdk10 integration wave 1

2017-04-03 Thread Martin Buchholz
Thanks! On Mon, Apr 3, 2017 at 1:05 PM, Paul Sandoz wrote: > Hi, > > Looks good. > > It’s trivial but we probably require a CCC for ScheduledThreadPoolExecutor > calling out the NPE for null unit argument values, to clarify pool sizes of > TPE, and to clarify that AbortPolicy default handler for

Re: RFR: jsr166 jdk10 integration wave 1

2017-04-03 Thread Paul Sandoz
Hi, Looks good. It’s trivial but we probably require a CCC for ScheduledThreadPoolExecutor calling out the NPE for null unit argument values, to clarify pool sizes of TPE, and to clarify that AbortPolicy default handler for TPE *and* STPE. We are not quite there yet with the CCC being open (so

Re: RFR: jsr166 jdk10 integration wave 1

2017-03-30 Thread Martin Buchholz
OK, this wave is open for review again. On Wed, Mar 29, 2017 at 12:57 PM, Martin Buchholz wrote: > Oops. Martin forgot to check ScheduledExecutorService, and there's some > overlap in specs, which requires some rework. > > On Wed, Mar 29, 2017 at 11:43 AM, Martin Buchholz > wrote: > >> First j

Re: RFR: jsr166 jdk10 integration wave 1

2017-03-29 Thread Martin Buchholz
Oops. Martin forgot to check ScheduledExecutorService, and there's some overlap in specs, which requires some rework. On Wed, Mar 29, 2017 at 11:43 AM, Martin Buchholz wrote: > First jdk10 integration > > http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/ > > Mostly focuse

RFR: jsr166 jdk10 integration wave 1

2017-03-29 Thread Martin Buchholz
First jdk10 integration http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/ Mostly focused on thread pools.