On Mon, 6 Jun 2022 16:54:29 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Double.java line 683:
>>
>>> 681: * "[\\x00-\\x20]*");// Optional trailing "whitespace"
>>> 682: *
>>> 683: * if (Pattern.matches(fpRegex, myString)) // @link
>>> substring="Pattern.
On Mon, 6 Jun 2022 05:29:24 GMT, Alan Bateman wrote:
> One other thing you could do is link Pattern.matches in the snippet to the
> matches method.
Suggestion made in subsequent push; thanks.
> src/java.base/share/classes/java/lang/Double.java line 683:
>
>> 681: * "[\\x00-\\x20]*"
On Mon, 6 Jun 2022 20:37:07 GMT, Joe Darcy wrote:
>> Various code blocks in Float and Double would be better as snippets.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Use idiom for shorter lines
> - Respond to review fee
> Various code blocks in Float and Double would be better as snippets.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Use idiom for shorter lines
- Respond to review feedback.
-
Changes:
- all: https://git.openjdk.jav
On Sun, 5 Jun 2022 21:19:37 GMT, Joe Darcy wrote:
> Various code blocks in Float and Double would be better as snippets.
src/java.base/share/classes/java/lang/Double.java line 643:
> 641: * expression below can be used to screen the input string:
> 642: *
> 643: * {@snippet lang
On Sun, 5 Jun 2022 21:19:37 GMT, Joe Darcy wrote:
> Various code blocks in Float and Double would be better as snippets.
One other thing you could do is link Pattern.matches in the snippet to the
matches method.
-
Marked as reviewed by alanb (Reviewer).
PR: https://git.openjdk.ja
Various code blocks in Float and Double would be better as snippets.
-
Commit messages:
- JDK-8287838: Update Float and Double to use snippets
Changes: https://git.openjdk.java.net/jdk/pull/9034/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9034&range=00
Issue: http
