Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v4]

2021-09-15 Thread Ioi Lam
On Wed, 15 Sep 2021 07:46:34 GMT, Matthias Baesken wrote: >> https://bugs.openjdk.java.net/browse/JDK-8266490 >> extended the OSContainer API in order to also support the pids controller of >> cgroups. However only pids.max output was added with 8266490. >> There is a second parameter pids.curre

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v4]

2021-09-15 Thread Severin Gehwolf
On Wed, 15 Sep 2021 07:46:34 GMT, Matthias Baesken wrote: >> https://bugs.openjdk.java.net/browse/JDK-8266490 >> extended the OSContainer API in order to also support the pids controller of >> cgroups. However only pids.max output was added with 8266490. >> There is a second parameter pids.curre

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]

2021-09-15 Thread Matthias Baesken
On Wed, 15 Sep 2021 07:09:54 GMT, Matthias Baesken wrote: >>> Maybe it should be "any_integer"? >> >> +1 > >> Is "no_value_expected" generated by Docker? I searched the entire HotSpot >> source code and couldn't find it. I also couldn't find "WARNING: Your kernel >> does not support pids limit

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v2]

2021-09-15 Thread Matthias Baesken
On Fri, 10 Sep 2021 12:36:35 GMT, Severin Gehwolf wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Some simplifications and test adjustment suggested by Severin > > test/hotspot/jtreg/containers/docker/TestPids.

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v4]

2021-09-15 Thread Matthias Baesken
> https://bugs.openjdk.java.net/browse/JDK-8266490 > extended the OSContainer API in order to also support the pids controller of > cgroups. However only pids.max output was added with 8266490. > There is a second parameter pids.current , see > https://www.kernel.org/doc/html/latest/admin-guide/c

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]

2021-09-15 Thread Matthias Baesken
On Tue, 14 Sep 2021 18:23:49 GMT, Severin Gehwolf wrote: >> Oh, I misunderstood the test. "no_value_expected" was passed in from >> `testPids()` in this file, but that's confusing because you are expecting an >> integer value. Maybe it should be "any_integer"? > >> Maybe it should be "any_integ

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]

2021-09-14 Thread Severin Gehwolf
On Tue, 14 Sep 2021 17:25:05 GMT, Ioi Lam wrote: > Maybe it should be "any_integer"? +1 - PR: https://git.openjdk.java.net/jdk/pull/5437

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]

2021-09-14 Thread Ioi Lam
On Tue, 14 Sep 2021 16:36:24 GMT, Ioi Lam wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Simplify coding following Severins advice > > test/hotspot/jtreg/containers/docker/TestPids.java line 97: > >> 95:

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]

2021-09-14 Thread Ioi Lam
On Tue, 14 Sep 2021 14:27:36 GMT, Matthias Baesken wrote: >> https://bugs.openjdk.java.net/browse/JDK-8266490 >> extended the OSContainer API in order to also support the pids controller of >> cgroups. However only pids.max output was added with 8266490. >> There is a second parameter pids.curre

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]

2021-09-14 Thread Severin Gehwolf
On Tue, 14 Sep 2021 14:27:36 GMT, Matthias Baesken wrote: >> https://bugs.openjdk.java.net/browse/JDK-8266490 >> extended the OSContainer API in order to also support the pids controller of >> cgroups. However only pids.max output was added with 8266490. >> There is a second parameter pids.curre

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v2]

2021-09-14 Thread Matthias Baesken
On Fri, 10 Sep 2021 11:07:52 GMT, Matthias Baesken wrote: >> https://bugs.openjdk.java.net/browse/JDK-8266490 >> extended the OSContainer API in order to also support the pids controller of >> cgroups. However only pids.max output was added with 8266490. >> There is a second parameter pids.curre

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v3]

2021-09-14 Thread Matthias Baesken
> https://bugs.openjdk.java.net/browse/JDK-8266490 > extended the OSContainer API in order to also support the pids controller of > cgroups. However only pids.max output was added with 8266490. > There is a second parameter pids.current , see > https://www.kernel.org/doc/html/latest/admin-guide/c

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v2]

2021-09-10 Thread Severin Gehwolf
On Fri, 10 Sep 2021 11:07:52 GMT, Matthias Baesken wrote: >> https://bugs.openjdk.java.net/browse/JDK-8266490 >> extended the OSContainer API in order to also support the pids controller of >> cgroups. However only pids.max output was added with 8266490. >> There is a second parameter pids.curre

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current [v2]

2021-09-10 Thread Matthias Baesken
> https://bugs.openjdk.java.net/browse/JDK-8266490 > extended the OSContainer API in order to also support the pids controller of > cgroups. However only pids.max output was added with 8266490. > There is a second parameter pids.current , see > https://www.kernel.org/doc/html/latest/admin-guide/c

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current

2021-09-10 Thread Matthias Baesken
On Thu, 9 Sep 2021 09:21:59 GMT, Matthias Baesken wrote: > https://bugs.openjdk.java.net/browse/JDK-8266490 > extended the OSContainer API in order to also support the pids controller of > cgroups. However only pids.max output was added with 8266490. > There is a second parameter pids.current ,

Re: RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current

2021-09-09 Thread Severin Gehwolf
On Thu, 9 Sep 2021 09:21:59 GMT, Matthias Baesken wrote: > https://bugs.openjdk.java.net/browse/JDK-8266490 > extended the OSContainer API in order to also support the pids controller of > cgroups. However only pids.max output was added with 8266490. > There is a second parameter pids.current ,

RFR: JDK-8273526: Extend the OSContainer API pids controller with pids.current

2021-09-09 Thread Matthias Baesken
https://bugs.openjdk.java.net/browse/JDK-8266490 extended the OSContainer API in order to also support the pids controller of cgroups. However only pids.max output was added with 8266490. There is a second parameter pids.current , see https://www.kernel.org/doc/html/latest/admin-guide/cgroup-v2.h