Re: RFR: JDK-8248254: jpackage fails if app module is in external runtime

2020-06-27 Thread Andy Herrick
Looks good. /Andy On 6/26/2020 7:30 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Fix jpackage code to be able to locate app module if it is linked in external runtime. The suggested fix only verifies if app module exists in external runtime. It doesn't extract versi

Re: RFR: JDK-8248254: jpackage fails if app module is in external runtime

2020-06-26 Thread alexander . matveev
Hi Alexey, Looks good. Thanks, Alexander On 6/26/20 4:30 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Fix jpackage code to be able to locate app module if it is linked in external runtime. The suggested fix only verifies if app module exists in external runtime. It

RFR: JDK-8248254: jpackage fails if app module is in external runtime

2020-06-26 Thread Alexey Semenyuk
Please review fix [2] for jpackage bug [1]. Fix jpackage code to be able to locate app module if it is linked in external runtime. The suggested fix only verifies if app module exists in external runtime. It doesn't extract version and main class from modules in exetrnal runtime. To address th