There are still ongoing discussions (as comments on
https://bugs.openjdk.java.net/browse/JDK-8232806) as to whether the performance
implications and loss of reference equality caused by this change are
acceptable for the GraalVM Native Image.
I would suggest to hold off merging this change unt
Hi Vojin,
I think it would be useful to include such a test (for capturing and
non-capturing) to protect against a regression.
Thanks,
Paul.
> On Oct 29, 2019, at 3:57 AM, Vojin Jovanovic
> wrote:
>
> The only way I see to test this (without calling LMF directly) is to inspect
> the stack t
Looks good to me.
Remi
On October 28, 2019 10:29:58 PM UTC, mark.reinh...@oracle.com wrote:
>2019/10/28 11:10:25 -0700, vojin.jovano...@oracle.com:
>> This email proposes a change to the LambdaMetaFactory that allows to
>> disable eager initialization (with Unsafe) of generated lambdas. ...
>>
>
The only way I see to test this (without calling LMF directly) is to inspect
the stack trace created in a static initialiser of a lambda super-type. The
stack trace should not contain LMF when
-Djdk.internal.lambda.disableEagerInitialization=true. Let me know if this kind
of a test reasonable;
> On Oct 28, 2019, at 3:29 PM, mark.reinh...@oracle.com wrote:
>
> 2019/10/28 11:10:25 -0700, vojin.jovano...@oracle.com:
>> This email proposes a change to the LambdaMetaFactory that allows to
>> disable eager initialization (with Unsafe) of generated lambdas. ...
>>
>> ...
>>
>> After the di
2019/10/28 11:10:25 -0700, vojin.jovano...@oracle.com:
> This email proposes a change to the LambdaMetaFactory that allows to
> disable eager initialization (with Unsafe) of generated lambdas. ...
>
> ...
>
> After the discussion with Brian Goetz, we have trimmed down to the
> following change:
>
The patch seems suitably minimal to me to meet the goals and not cause
difficulty for future evolution of LMF (for which we have some plans,
once some other VM work finishes up.) Essentially, the
disable-eager-initialization case disables the caching optimization for
non-capturing lambdas, an
Hi all,
This email proposes a change to the LambdaMetaFactory that allows to disable
eager initialization (with Unsafe) of generated lambdas. This is needed by the
GraalVM Native Image, as initialization of lambdas during AOT compilation
breaks our heap snapshotting (via initialization of inte
