Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-25 Thread Remi Forax
- Mail original - > De: "John Rose" > À: "Ioi Lam" > Cc: "core-libs-dev" , "hotspot-runtime-dev" > > Envoyé: Lundi 24 Juin 2019 19:13:04 > Objet: Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders > On

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-24 Thread John Rose
On Jun 20, 2019, at 12:12 AM, Ioi Lam wrote: > ... > I have a rough idea -- let's have a higher-level representation of the > bytecode stream than byte[] or ByteBuffer, to make optimization possible. Template classes will need something similar, so maybe there is a common design point in here.

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-23 Thread Jiangli Zhou
Hi Yumin, Sorry for the late reply. On Thu, Jun 20, 2019 at 10:01 AM yumin qi wrote: > > HI, Jiangli > > Thanks for your comments. > Yes, the implementation may land on adding a public API. > Are the custom loaded classes treated well enough now with dynamic > dump/share? I haven't checke

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-20 Thread Ioi Lam
On 6/20/19 10:35 AM, Alan Bateman wrote: On 20/06/2019 17:50, yumin qi wrote: Hi, Alan and Ioi   Thanks. Forget to add core-libs-dev for the review.   If add a public API, surely it should be discussed in detail the design, implementation and effects. One question, will adding a public API

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-20 Thread Mandy Chung
On 6/20/19 10:35 AM, Alan Bateman wrote: On 20/06/2019 17:50, yumin qi wrote: Hi, Alan and Ioi   Thanks. Forget to add core-libs-dev for the review.   If add a public API, surely it should be discussed in detail the design, implementation and effects. One question, will adding a public API

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-20 Thread Alan Bateman
On 20/06/2019 17:50, yumin qi wrote: Hi, Alan and Ioi   Thanks. Forget to add core-libs-dev for the review.   If add a public API, surely it should be discussed in detail the design, implementation and effects. One question, will adding a public API for ClassLoader need go some process like CSR

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-20 Thread yumin qi
HI, Jiangli Thanks for your comments. Yes, the implementation may land on adding a public API. Are the custom loaded classes treated well enough now with dynamic dump/share? I haven't checked that recently. Thanks Yumin On Thu, Jun 20, 2019 at 8:08 AM Jiangli Zhou wrote: > Hi Yumin, > >

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-20 Thread yumin qi
Hi, Alan and Ioi Thanks. Forget to add core-libs-dev for the review. If add a public API, surely it should be discussed in detail the design, implementation and effects. One question, will adding a public API for ClassLoader need go some process like CSR? I did not add public API here and tri

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-20 Thread Ioi Lam
On 6/19/19 11:36 PM, Alan Bateman wrote: On 20/06/2019 02:36, yumin qi wrote: Hi, Please review: bug: https://bugs.openjdk.java.net/browse/JDK-8222373 webrev: http://cr.openjdk.java.net/~minqi/8222373/01/ To load shared class from CDS, first class file stream is read from jar file, then load

Re: RFR: JDK-8222373 Improve CDS performance for custom class loaders

2019-06-19 Thread Alan Bateman
On 20/06/2019 02:36, yumin qi wrote: Hi, Please review: bug: https://bugs.openjdk.java.net/browse/JDK-8222373 webrev: http://cr.openjdk.java.net/~minqi/8222373/01/ To load shared class from CDS, first class file stream is read from jar file, then load the class with the stream. In vm, the stream