Re: RFR: JDK-8011920 (Main implementation classes for java.util.stream)

2013-04-18 Thread Jonathan Gibbons
Brian, Are you asking for people to review the code, just to get some warm fuzzy feedback, or are you asking for a formal review of the code with the direct goal of pushing 15K LOC into jdk8/tl with no corresponding tests. If you are looking to push bits soon, why can't you wait until you hav

RFR: JDK-8011920 (Main implementation classes for java.util.stream)

2013-04-18 Thread Brian Goetz
This is a review request for the bulk of the java.util.stream implementation; webrev at: http://cr.openjdk.java.net/~briangoetz/JDK-8011920/webrev/ You might ask: with 15,000 lines of new code, why are there no tests? The simple answer is: we've got plenty of 'em, but they can't be put back