bject: Re: RFR: Implement RandomAccess spliterator
Hi Hiroshi,
I created an issue and made some edits:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8158365-list-spliterator-rnd-access/webrev/
Let me know what you think.
Specification-wise we need to describe how the default implementation s
dressed my
> issue earlier.
>
> Thanks,
> Hiroshi
>
> -Original Message-
> From: Paul Sandoz [mailto:paul.san...@oracle.com]
> Sent: Thursday, May 12, 2016 8:46 PM
> To: Ito, Hiroshi [Tech]
> Cc: core-libs-dev@openjdk.java.net; Chan, Sunny [Tech]; Raab, Don
onfusion about SubList. It was all about the
IH> concurrent modification checking, so adding the change above pretty
IH> much addressed my issue earlier.
IH> Thanks,
IH> Hiroshi
IH> -Original Message-
IH> From: Paul Sandoz [mailto:paul.san...@oracle.com]
IH> Sent: Thu
; Paul Sandoz
Cc: Raab, Donald [Tech]; core-libs-dev@openjdk.java.net; Chan, Sunny [Tech]
Subject: Re: RFR: Implement RandomAccess spliterator
Hello!
(disclaimer: I'm not an official reviewer)
> ((AbstractList) lst).modCount;
Raw-type casts should be replaced with AbstractList to
issue earlier.
IH> Thanks,
IH> Hiroshi
IH> -Original Message-
IH> From: Paul Sandoz [mailto:paul.san...@oracle.com]
IH> Sent: Thursday, May 12, 2016 8:46 PM
IH> To: Ito, Hiroshi [Tech]
IH> Cc: core-libs-dev@openjdk.java.net; Chan, Sunny [Tech]; Raab, Donald [Tech]
I
-Original Message-
From: Paul Sandoz [mailto:paul.san...@oracle.com]
Sent: Thursday, May 12, 2016 8:46 PM
To: Ito, Hiroshi [Tech]
Cc: core-libs-dev@openjdk.java.net; Chan, Sunny [Tech]; Raab, Donald [Tech]
Subject: Re: RFR: Implement RandomAccess spliterator
Hi Hiroshi,
This is a good
Hi Hiroshi,
This is a good example of what seems like a small feature and yet there are
some unexpected complexities :-)
We will need to refine the implementation specification of List.spliterator,
which currently states:
* @implSpec
* The default implementation creates a
* late-binding split
Hi,
Please kindly review the attached patch for RandomAccessSpliterator
implementation.
Currently default implementation of spliterator is an IteratorSpliterator which
is not optimal for RandomAccess data structures (besides ArrayList and Vector).
This patch is to provide a default RandomAcces