Re: RFR: CSR Core-libs support for records

2019-11-05 Thread Vicente Romero
I have updated the CSR after some feedback, please take a look at it. I have added some comments to the bug entry describing the last changes Thanks, Vicente On 11/4/19 3:54 PM, Vicente Romero wrote: Hi, Please review the draft of the CSR for Core-libs support for records at [1] Thanks, Vi

Re: RFR: CSR Core-libs support for records

2019-11-05 Thread Chris Hegarty
> On 4 Nov 2019, at 23:22, Joe Darcy wrote: > ... > It isn't unreasonable for java.lang.Record to make some mention of the > special treatment by serialization. (As a point of reference, java.lang.Enum > does *not* reference the special handling of enums of serialization.) > > I think a refe

Re: RFR: CSR Core-libs support for records

2019-11-05 Thread Chris Hegarty
> On 4 Nov 2019, at 21:27, Florian Weimer wrote: > > ... > Right now, it appears to be possible to have a record implement > java.io.Serializable, and serialization will appear to work, but > because the names of the implicitly generated private fields are not > specified, it is not portable a

Re: RFR: CSR Core-libs support for records

2019-11-04 Thread Joe Darcy
Hello, On 11/4/2019 1:27 PM, Florian Weimer wrote: * Vicente Romero: Please review the draft of the CSR for Core-libs support for records at [1] Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8233436 I would have expected something regarding serialization in the description of

Re: RFR: CSR Core-libs support for records

2019-11-04 Thread Florian Weimer
* Vicente Romero: > Please review the draft of the CSR for Core-libs support for records at [1] > > Thanks, > Vicente > > [1] https://bugs.openjdk.java.net/browse/JDK-8233436 I would have expected something regarding serialization in the description of java.lang.Record. Right now, it appears to

RFR: CSR Core-libs support for records

2019-11-04 Thread Vicente Romero
Hi, Please review the draft of the CSR for Core-libs support for records at [1] Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8233436