Re: RFR: 8285745: Re-examine PushbackInputStream mark/reset

2022-04-27 Thread Alan Bateman
On Wed, 27 Apr 2022 20:10:03 GMT, Brian Burkhalter wrote: > Please review this request to remove the `synchronized` keyword from the > `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`. Marked as reviewed by alanb (Reviewer). - PR: https://git.openjdk.java.net/jdk

Re: RFR: 8285745: Re-examine PushbackInputStream mark/reset

2022-04-27 Thread Jaikiran Pai
On Wed, 27 Apr 2022 20:10:03 GMT, Brian Burkhalter wrote: > Please review this request to remove the `synchronized` keyword from the > `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`. Looks fine to me. Given that `mark()` currently is a no-op and `reset()` throws an exception

Re: RFR: 8285745: Re-examine PushbackInputStream mark/reset

2022-04-27 Thread Brian Burkhalter
On Wed, 27 Apr 2022 20:10:03 GMT, Brian Burkhalter wrote: > Please review this request to remove the `synchronized` keyword from the > `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`. Please see also https://github.com/openjdk/jdk/pull/8309. - PR: https://git.op

RFR: 8285745: Re-examine PushbackInputStream mark/reset

2022-04-27 Thread Brian Burkhalter
Please review this request to remove the `synchronized` keyword from the `mark(int)` and `reset()` methods of `java.io.PushbackInputStream`. - Commit messages: - 8285745: Re-examine PushbackInputStream mark/reset Changes: https://git.openjdk.java.net/jdk/pull/8433/files Webrev: ht