Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Thanks @turbanoff , left off the JBS ID in the comment. - PR: https://git.openjdk.java.net/jdk/pull/7201

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match [v2]

2022-01-24 Thread Ian Graves
> Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Ian Graves has updated the pull request incrementally with one additional commit since the last revision: Fixing docs and dates - Changes: - all: https://git.openjdk.java.n

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Andrey Turbanov
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException test/jdk/java/util/regex/RegExTest.java line 4551: > 4549: } > 4550: > 4551: //This test is for This comment is confusing. Shou

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Roger Riggs
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7201

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Naoto Sato
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7201

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Iris Clark
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7201

Re: RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Lance Andersen
On Mon, 24 Jan 2022 17:21:57 GMT, Ian Graves wrote: > Replacing a buggy NullPointerException in `Pattern.compile()` with the proper > PatternSyntaxException Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7201

RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
Replacing a buggy NullPointerException in `Pattern.compile()` with the proper PatternSyntaxException - Commit messages: - 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match Changes: https://git.openjdk.java.net/jdk/pull/7201/files Webrev: https://webre

RFR: 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match

2022-01-24 Thread Ian Graves
Replacing a buggy NPE with a PatternSyntaxException for cases with a bad intersection operator. - Commit messages: - 8280403: RegEx: String.split can fail with NPE in Pattern.CharPredicate::match Changes: https://git.openjdk.java.net/jdk/pull/7199/files Webrev: https://webrevs.op