On Wed, 6 Apr 2022 15:54:30 GMT, Naoto Sato wrote:
> Looks good to me. This would have been a premiere example for switch pattern
> match, but hey.
Yeah, totally understand the urge to use new features.
-
PR: https://git.openjdk.java.net/jdk/pull/8116
On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang wrote:
>> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
>> classes where the checks were really about equality or whether they were the
>> exact class types. It was why they worked nonetheless even though some of
>> them were
On Wed, 6 Apr 2022 01:23:15 GMT, Joe Wang wrote:
>> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
>> classes where the checks were really about equality or whether they were the
>> exact class types. It was why they worked nonetheless even though some of
>> them were
On Tue, 5 Apr 2022 23:55:22 GMT, Naoto Sato wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> replace with instanceof
>
> src/java.xml/share/classes/jdk/xml/internal/JdkXmlFeatures.java line 326:
>
>> 324: public vo
> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
> classes where the checks were really about equality or whether they were the
> exact class types. It was why they worked nonetheless even though some of
> them were backwards.
>
> Test: existing tests passed.
Joe Wang
On Tue, 5 Apr 2022 23:05:47 GMT, Joe Wang wrote:
> Clean up the usages of isAssignableFrom in a few xpath and jdk/internal
> classes where the checks were really about equality or whether they were the
> exact class types. It was why they worked nonetheless even though some of
> them were back
Clean up the usages of isAssignableFrom in a few xpath and jdk/internal classes
where the checks were really about equality or whether they were the exact
class types. It was why they worked nonetheless even though some of them were
backwards.
Test: existing tests passed.
-
Commit
