On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last
On Wed, 20 Oct 2021 22:14:33 GMT, Vladimir Kozlov wrote:
> Tests passed. You can integrate changes.
Thanks Vladimir! What are the next steps to integrate the change?
-
PR: https://git.openjdk.java.net/jdk/pull/5933
On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last
On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last
On Tue, 19 Oct 2021 20:34:55 GMT, Vamsi Parasa wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> Vamsi Parasa has updated the pull request incrementally with one additional
> commit since the last
On Fri, 15 Oct 2021 20:19:31 GMT, Vladimir Kozlov wrote:
>>> How you verified correctness of results? I suggest to extend
>>> `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned
>>> method.
>>
>> Tests for unsignedMultiplyHigh were already added in
>> test/jdk//java/lan
On Fri, 15 Oct 2021 19:31:24 GMT, Vamsi Parasa wrote:
>> src/hotspot/share/opto/mulnode.cpp line 468:
>>
>>> 466: }
>>> 467:
>>> 468:
>>> //=
>>
>> MulHiLNode::Value() and UMulHiLNode::Value() seem to be identical. Pe
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
Vamsi Parasa has updated the pull request incrementally with one additional
commit since the last revision:
refactoring to remove code duplication by using a
On Fri, 15 Oct 2021 21:04:12 GMT, Vamsi Parasa wrote:
> > > How you verified correctness of results? I suggest to extend
> > > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover
> > > unsigned method.
> >
> >
> > Tests for unsignedMultiplyHigh were already added in
> > test/jd
On Fri, 15 Oct 2021 20:19:31 GMT, Vladimir Kozlov wrote:
> > > How you verified correctness of results? I suggest to extend
> > > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover
> > > unsigned method.
> >
> >
> > Tests for unsignedMultiplyHigh were already added in
> > test
On Fri, 15 Oct 2021 19:19:13 GMT, Vamsi Parasa wrote:
> > How you verified correctness of results? I suggest to extend
> > `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned
> > method.
>
> Tests for unsignedMultiplyHigh were already added in
> test/jdk//java/lang/Math
On Fri, 15 Oct 2021 16:14:25 GMT, Andrew Haley wrote:
>> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
>> This change show 1.87X improvement on a micro benchmark.
>
> src/hotspot/share/opto/mulnode.cpp line 468:
>
>> 466: }
>> 467:
>> 468:
>> //
On Fri, 15 Oct 2021 18:45:41 GMT, Vladimir Kozlov wrote:
> How you verified correctness of results? I suggest to extend
> `test/jdk//java/lang/Math/MultiplicationTests.java` test to cover unsigned
> method.
Tests for unsignedMultiplyHigh were already added in
test/jdk//java/lang/Math/Multipli
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
How you verified correctness of results?
I suggest to extend `test/jdk//java/lang/Math/MultiplicationTests
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
test/micro/org/openjdk/bench/java/lang/MathBench.java line 547:
> 545: return Math.unsignedMulti
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
src/hotspot/share/opto/mulnode.cpp line 468:
> 466: }
> 467:
> 468:
> //===
On Wed, 13 Oct 2021 18:55:10 GMT, Vamsi Parasa wrote:
> Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction.
> This change show 1.87X improvement on a micro benchmark.
The `java.lang.Math` change looks good, of course. On the rest I cannot comment
but it is good to see som
Optimize the new Math.unsignedMultiplyHigh using the x86 mul instruction. This
change show 1.87X improvement on a micro benchmark.
-
Commit messages:
- fix typo in function name
- 8275167: x86 intrinsic for unsignedMultiplyHigh
Changes: https://git.openjdk.java.net/jdk/pull/5933/f
18 matches
Mail list logo
