Re: RFR: 8266857: PipedOutputStream.sink should be volatile

2021-05-11 Thread Liam Miller-Cushon
On Tue, 11 May 2021 10:19:52 GMT, Daniel Fuchs wrote: > For correctness (and peace of mind)- we should probably introduce a local > variable in all the places where `sink` is read more than once outside of a > synchronized block Done, thanks! - PR: https://git.openjdk.java.net/jd

Re: RFR: 8266857: PipedOutputStream.sink should be volatile [v2]

2021-05-11 Thread Daniel Fuchs
On Tue, 11 May 2021 15:47:37 GMT, Liam Miller-Cushon wrote: >> 8266857: PipedOutputStream.sink should be volatile > > Liam Miller-Cushon has refreshed the contents of this pull request, and > previous commits have been removed. The incremental views will show > differences compared to the previ

Re: RFR: 8266857: PipedOutputStream.sink should be volatile [v2]

2021-05-11 Thread Liam Miller-Cushon
> 8266857: PipedOutputStream.sink should be volatile Liam Miller-Cushon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since

Re: RFR: 8266857: PipedOutputStream.sink should be volatile

2021-05-11 Thread Daniel Fuchs
On Mon, 10 May 2021 23:25:46 GMT, Liam Miller-Cushon wrote: > 8266857: PipedOutputStream.sink should be volatile For correctness (and peace of mind)- we should probably introduce a local variable in all the places where `sink` is read more than once outside of a synchronized block (the two `wr

RFR: 8266857: PipedOutputStream.sink should be volatile

2021-05-10 Thread Liam Miller-Cushon
8266857: PipedOutputStream.sink should be volatile - Commit messages: - 8266857: PipedOutputStream.sink should be volatile Changes: https://git.openjdk.java.net/jdk/pull/3960/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3960&range=00 Issue: https://bugs.openjdk.jav