Re: RFR: 8263105: security-libs doclint cleanup [v4]

2021-03-10 Thread Bradford Wetmore
On Mon, 8 Mar 2021 19:50:06 GMT, Bradford Wetmore wrote: >> src/java.base/share/classes/java/security/BasicPermission.java line 497: >> >>> 495: /** >>> 496: * @serialData Default fields. >>> 497: */ >> >> FWIW, this doc comment will be ignored, because it will be superseded by th

Re: RFR: 8263105: security-libs doclint cleanup [v4]

2021-03-10 Thread Bradford Wetmore
> Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files. Bradford Wetmore has updated the pull request incrementally w

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Bradford Wetmore
On Wed, 10 Mar 2021 19:02:40 GMT, Sean Mullan wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More Codereview Comments > > src/java.base/share/classes/java/security/PrivilegedActionException.java line > 101: >

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-10 Thread Bradford Wetmore
On Wed, 10 Mar 2021 15:10:35 GMT, Roger Riggs wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Codereview Comment > > src/java.base/share/classes/javax/crypto/SealedObject.java line 425: > >> 423: * Restor

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Bradford Wetmore
On Wed, 10 Mar 2021 14:53:53 GMT, Roger Riggs wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More Codereview Comments > > src/java.base/share/classes/java/security/AllPermission.java line 165: > >> 163: >> 1

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Sean Mullan
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Iris Clark
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-10 Thread Roger Riggs
On Tue, 9 Mar 2021 22:19:28 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-10 Thread Roger Riggs
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v3]

2021-03-09 Thread Bradford Wetmore
> Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files. Bradford Wetmore has updated the pull request incrementally w

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-09 Thread Sean Mullan
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-09 Thread Bradford Wetmore
On Tue, 9 Mar 2021 16:10:11 GMT, Sean Mullan wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Codereview Comment > > src/java.base/share/classes/javax/crypto/SealedObject.java line 428: > >> 426: * @throws

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-09 Thread Sean Mullan
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-09 Thread Daniel Fuchs
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-08 Thread Joe Darcy
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup [v2]

2021-03-08 Thread Bradford Wetmore
> Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files. Bradford Wetmore has updated the pull request incrementally w

Re: RFR: 8263105: security-libs doclint cleanup

2021-03-08 Thread Iris Clark
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote: > Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files. I'

Re: RFR: 8263105: security-libs doclint cleanup

2021-03-08 Thread Bradford Wetmore
On Sat, 6 Mar 2021 19:20:39 GMT, Jonathan Gibbons wrote: >> Fix various things pointed out by the most recent doclint run in the >> security-libs area. >> >> This is docs only: I will be checking doccheck/doclint, and will be running >> tier1/tier2 tests. Minor spot checks on generated files

Re: RFR: 8263105: security-libs doclint cleanup

2021-03-08 Thread Jonathan Gibbons
On Sat, 6 Mar 2021 07:31:09 GMT, Bradford Wetmore wrote: > Fix various things pointed out by the most recent doclint run in the > security-libs area. > > This is docs only: I will be checking doccheck/doclint, and will be running > tier1/tier2 tests. Minor spot checks on generated files. I'

RFR: 8263105: security-libs doclint cleanup

2021-03-08 Thread Bradford Wetmore
Fix various things pointed out by the most recent doclint run in the security-libs area. This is docs only: I will be checking doccheck/doclint, and will be running tier1/tier2 tests. Minor spot checks on generated files. - Commit messages: - Final First Draft - Only 100 warnin