On Fri, 12 Feb 2021 22:48:51 GMT, Mandy Chung wrote:
>> This more limited cleanup looks good.
>
> This patch changes `JVM_FindLoadedClass` interface to only accept a binary
> name. It used to accept both a binary name and internal form. Most, if not
> all, JVM entry points take the name of i
On Fri, 12 Feb 2021 02:10:02 GMT, Coleen Phillimore wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Consolidate verifyClassname and verifyFixClassname
>
> This more limited cleanup looks good.
This patch changes
On Thu, 11 Feb 2021 12:44:54 GMT, Claes Redestad wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> Claes Redestad has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Thu, 4 Feb 2021 13:14:16 GMT, Coleen Phillimore wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Consolidate verifyClassname and verifyFixClassname
>
> Changes requested by coleenp (Reviewer).
I tried to conso
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Consolidate verifyClassname and verifyFixClassname
---
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
Claes Redestad has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/re
On Thu, 4 Feb 2021 12:54:43 GMT, Coleen Phillimore wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> src/java.base/share/classes/java/lang/ClassLoader.java line 1259:
>
>> 1257: Class findBootstrapClassOrNull
On Wed, 3 Feb 2021 19:49:30 GMT, Mandy Chung wrote:
>> This patch moves some sanity checking done in ClassLoader.java to the
>> corresponding endpoints in native or VM code.
>
> src/java.base/share/native/libjava/ClassLoader.c line 291:
>
>> 289: }
>> 290: // disallow slashes in input,
On Thu, 4 Feb 2021 13:11:47 GMT, Coleen Phillimore wrote:
>> src/java.base/share/native/libjava/ClassLoader.c line 291:
>>
>>> 289: }
>>> 290: // disallow slashes in input, change '.' to '/'
>>> 291: if (verifyFixClassname(clname)) {
>>
>> perhaps we should replace all use of `fixCl
On Wed, 3 Feb 2021 12:21:30 GMT, Claes Redestad wrote:
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
Changes requested by coleenp (Reviewer).
src/java.base/share/classes/java/lang/ClassLoader.java line 1259:
> 1257:
On Wed, 3 Feb 2021 12:21:30 GMT, Claes Redestad wrote:
> This patch moves some sanity checking done in ClassLoader.java to the
> corresponding endpoints in native or VM code.
I'm unsure the benefit of moving the check done by `checkName` to the VM but
`preDefineClass` still calls `checkName`.
This patch moves some sanity checking done in ClassLoader.java to the
corresponding endpoints in native or VM code.
-
Commit messages:
- Copyrights
- Move class name checking for findBootstrapClass/findLoadedClass into
native/VM
Changes: https://git.openjdk.java.net/jdk/pull/2378
12 matches
Mail list logo
