Re: RFR: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469 [v2]

2021-01-20 Thread Lance Andersen
On Wed, 20 Jan 2021 13:03:04 GMT, Claes Redestad wrote: >> This patch resolves a thread-safety issue where the singleton UTF8ZipCoder >> is erroneously using a shared CharsetDecoder when the fast-path fails. It >> needs to go via JLA.newStringUTF8NoRepl like before JDK-8243469 >> >> This shoul

Re: RFR: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469 [v2]

2021-01-20 Thread Claes Redestad
> This patch resolves a thread-safety issue where the singleton UTF8ZipCoder is > erroneously using a shared CharsetDecoder when the fast-path fails. It needs > to go via JLA.newStringUTF8NoRepl like before JDK-8243469 > > This should resolve a rare issue when doing a lot of jar scanning in para

Re: RFR: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469 [v2]

2021-01-20 Thread Claes Redestad
On Wed, 20 Jan 2021 12:52:30 GMT, eirbjo wrote: >> Claes Redestad has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Reuse normalizedHash(String) >> - copyright >> - Don't use No Replace variant to calculate hash, more fixes > > src/

Re: RFR: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469

2021-01-20 Thread eirbjo
On Wed, 20 Jan 2021 12:21:21 GMT, Claes Redestad wrote: > This patch resolves a thread-safety issue where the singleton UTF8ZipCoder is > erroneously using a shared CharsetDecoder when the fast-path fails. It needs > to go via JLA.newStringUTF8NoRepl like before JDK-8243469 > > This should res

RFR: 8260010: UTF8ZipCoder not thread-safe since JDK-8243469

2021-01-20 Thread Claes Redestad
This patch resolves a thread-safety issue where the singleton UTF8ZipCoder is erroneously using a shared CharsetDecoder when the fast-path fails. It needs to go via JLA.newStringUTF8NoRepl like before JDK-8243469 This should resolve a rare issue when doing a lot of jar scanning in parallel on j