Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Roger Riggs
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/74

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Mandy Chung
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. +1 - Marked as reviewed by mchung (Reviewer). PR: https://git.openjdk.java.net/jdk/pul

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Jorn Vernee
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Looks good, though I'm not a Reviewer™, I'm the one who introduced this code. It is indeed a typo. T

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Brian Burkhalter
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Approved. - Marked as reviewed by bpb (Reviewer). PR: https://git.openjdk.java.net/jdk

Re: RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Brian Burkhalter
On Mon, 19 Oct 2020 18:08:28 GMT, Stuart Marks wrote: > This is a fix for "just a typo" or copy/paste error, but it probably requires > a CSR since it changes a normative > portion of the spec. Looks OK. - PR: https://git.openjdk.java.net/jdk/pull/744

RFR: 8255016: ConstantDescs.FALSE claims it represents TRUE

2020-10-19 Thread Stuart Marks
This is a fix for "just a typo" or copy/paste error, but it probably requires a CSR since it changes a normative portion of the spec. - Commit messages: - 8255016: ConstantDescs.FALSE claims it represents TRUE Changes: https://git.openjdk.java.net/jdk/pull/744/files Webrev: https: