On Wed, 14 Oct 2020 15:32:13 GMT, Aleksey Shipilev wrote:
>> Thanks for reviewing, @RogerRiggs - hopefully this is the last of 'em
>
> The benchmark is oddly written. I submitted
> https://bugs.openjdk.java.net/browse/JDK-8254782 -- to let original authors
> fix it up.
@shipilev yeah, seems rea
On Wed, 14 Oct 2020 15:23:31 GMT, Claes Redestad wrote:
>> Thanks for fixing these problems.
>
> Thanks for reviewing, @RogerRiggs - hopefully this is the last of 'em
The benchmark is oddly written. I submitted
https://bugs.openjdk.java.net/browse/JDK-8254782 -- to let original authors
fix it u
On Wed, 14 Oct 2020 15:13:00 GMT, Roger Riggs wrote:
>> - Illegal use of a unicode codepoint > \u as a char.
>> - Wrong class name.
>> - @Benchmark methods shouldn't be static.
>>
>> Each of these breaks the build, e.g. make build-microbenchmark fails, so it
>> seems the micro was never tes
On Wed, 14 Oct 2020 15:09:59 GMT, Claes Redestad wrote:
> - Illegal use of a unicode codepoint > \u as a char.
> - Wrong class name.
> - @Benchmark methods shouldn't be static.
>
> Each of these breaks the build, e.g. make build-microbenchmark fails, so it
> seems the micro was never tested
- Illegal use of a unicode codepoint > \u as a char.
- Wrong class name.
- @Benchmark methods shouldn't be static.
Each of these breaks the build, e.g. make build-microbenchmark fails, so it
seems the micro was never tested..?
This patch fixes up the micro so it compiles, but makes no guaran