Re: RFR: 8253342: Fix typos in String.transform

2020-09-18 Thread Aleksey Shipilev
On Fri, 18 Sep 2020 08:53:34 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/lang/String.java line 3186: >> >>> 3184: * caller. >>> 3185: * >>> 3186: * @param fa function to apply >> >> Shouldn't this be "_the_ function to apply"? Grep for other instance of >> "f

Re: RFR: 8253342: Fix typos in String.transform

2020-09-18 Thread Aleksey Shipilev
On Fri, 18 Sep 2020 08:27:44 GMT, Pavel Rappo wrote: > To confirm that this would not require a CSR I asked Joe Darcy. Joe replied > that this would NOT require a CSR. Changing the review from "Request Changes" to just "Comment. - PR: https://git.openjdk.java.net/jdk/pull/238

Re: RFR: 8253342: Fix typos in String.transform

2020-09-18 Thread Jim Laskey
On Fri, 18 Sep 2020 08:27:44 GMT, Pavel Rappo wrote: > To confirm that this would not require a CSR I asked Joe Darcy. Joe replied > that this would NOT require a CSR. Marked as reviewed by jlaskey (Reviewer). Marked as reviewed by jlaskey (Reviewer). - PR: https://git.openjdk.ja

Re: RFR: 8253342: Fix typos in String.transform

2020-09-18 Thread Pavel Rappo
On Fri, 18 Sep 2020 08:46:45 GMT, Aleksey Shipilev wrote: >> To confirm that this would not require a CSR I asked Joe Darcy. Joe replied >> that this would NOT require a CSR. > > src/java.base/share/classes/java/lang/String.java line 3186: > >> 3184: * caller. >> 3185: * >> 3186:

Re: RFR: 8253342: Fix typos in String.transform

2020-09-18 Thread Aleksey Shipilev
On Fri, 18 Sep 2020 08:27:44 GMT, Pavel Rappo wrote: > To confirm that this would not require a CSR I asked Joe Darcy. Joe replied > that this would NOT require a CSR. Changes requested by shade (Reviewer). src/java.base/share/classes/java/lang/String.java line 3186: > 3184: * caller. >

RFR: 8253342: Fix typos in String.transform

2020-09-18 Thread Pavel Rappo
To confirm that this would not require a CSR I asked Joe Darcy. Joe replied that this would NOT require a CSR. - Commit messages: - Initial commit Changes: https://git.openjdk.java.net/jdk/pull/238/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=238&range=00 Issue: h