Re: RFR: 8250803: pkgbuild failed with exit code 134

2020-08-14 Thread Andy Herrick
looks good. /Andy On 8/13/2020 4:13 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing timeout by 1 min fixed issues. In fix it is increased by 50% just in case. Without tim

Re: RFR: 8250803: pkgbuild failed with exit code 134

2020-08-13 Thread alexander . matveev
Hi Joe, None. Most time is spend when pkgbuild is executed which is external tool. Based on log our code does not consume a lot of time during execution. Based on one of the runs total time was 11 min: 1 min for jlink, 4 min for hdutil create and 4 min for pkgbuild, so test itself took 2 min.

Re: RFR: 8250803: pkgbuild failed with exit code 134

2020-08-13 Thread Alexey Semenyuk
Looks good. - Alexey On 8/13/2020 4:13 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing timeout by 1 min fixed issues. In fix it is increased by 50% just in case. Without

Re: RFR: 8250803: pkgbuild failed with exit code 134

2020-08-13 Thread Joe Darcy
What steps were taken to make the test run faster instead of increasing the time out? cheers, -Joe On 8/13/2020 1:13 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing time

RFR: 8250803: pkgbuild failed with exit code 134

2020-08-13 Thread alexander . matveev
Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing timeout by 1 min fixed issues. In fix it is increased by 50% just in case. Without timeout increase it was reproducible 100% on one of test machine. With increased