Nice catch!
Thank you so much, Mandy.
On 2019/10/30 上午1:19, Mandy Chung wrote:
Hi Jie,
This looks good but I ran into test/jdk/tools/jlink/BasicTest failure
with OOME in some system configuration. I made a minor fix to the
cleanup of the configuration collections after the plugin executes.
Hi Jie,
This looks good but I ran into test/jdk/tools/jlink/BasicTest failure
with OOME in some system configuration. I made a minor fix to the
cleanup of the configuration collections after the plugin executes.
// Let it go
- speciesTypes = null;
- invokerTypes = nul
Hi Mandy,
Thanks for your review and help.
I think your refactoring is a nice improvement.
Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.03/
It seems much better now.
Testing:
- make test TEST="tier1 tier2 tier3" CONF=release
Thanks a lot.
Best regards,
Jie
On 2019/10/26 上午3:29,
On 10/23/19 11:21 PM, Jie Fu wrote:
Hi Mandy,
Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.02/
It seems better now.
It's better while I think this can be further simplified.
line 101 to 217 involves iterating on the default sets/map and then
create a new TreeSet and TreeMap an
Hi Mandy,
Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.02/
It seems better now.
If you're OK with the change, could you please sponsor it?
Thanks a lot.
Best regards,
Jie
On 2019/10/24 下午1:12, Mandy Chung wrote:
About the GenerateJLIClassesPlugin change, I mentioned the alternativ
Hi Jie,
The new test looks good, thanks.
About the GenerateJLIClassesPlugin change, I mentioned the alternative
way to implement it. I think you can avoid the resorting in the case
when the trace config file is present. I'd like to see the initialize
method builds a sorted speciesTypes, i
Hi Mandy,
Updated: http://cr.openjdk.java.net/~jiefu/8232864/webrev.01/
The JLinkReproducibleTest had been extended to test the case when the
default trace file is not present.
If you're OK with the change, could you please sponsor it?
Thanks a lot.
Best regards,
Jie
On 2019/10/24 上午2:37, M
Thanks Mandy for your review and comments.
I'll try to construct a reproducer. Thanks.
On 2019/10/24 上午2:37, Mandy Chung wrote:
On 10/23/19 12:16 AM, Jie Fu wrote:
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8232864
Webrev: http://cr.openjdk.java.net/~jiefu/8232864/webrev.00/
sp
Thanks Claes for your review and comments.
On 2019/10/23 下午6:49, Claes Redestad wrote:
Hi,
ideally the build step to generate default_jli_trace.txt should be
done independently of where the CDS feature is compiled in, but the
fix looks good regardless.
/Claes
On 2019-10-23 09:16, Jie Fu wrote
On 10/23/19 12:16 AM, Jie Fu wrote:
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8232864
Webrev: http://cr.openjdk.java.net/~jiefu/8232864/webrev.00/
speciesTypes, invokerTypes, callSiteTypes and dmhMethods are sorted
when the trace config is present (done in readTraceConfig).
Hi,
ideally the build step to generate default_jli_trace.txt should be
done independently of where the CDS feature is compiled in, but the
fix looks good regardless.
/Claes
On 2019-10-23 09:16, Jie Fu wrote:
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8232864
Webrev: http://cr.op
Hi Alan,
Thanks for looking at this.
On 2019/10/23 下午3:57, Alan Bateman wrote:
Would this test have caught this if it were run with CDS disables?
Yes. This bug was found while we were debugging the CDS feature on our
mips platform.
I'm just wondering if we need to add more run modes.
G
On 23/10/2019 08:16, Jie Fu wrote:
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8232864
Webrev: http://cr.openjdk.java.net/~jiefu/8232864/webrev.00/
To find out how to reproduce this bug, please refer to the JBS.
To keep things sorted in a deterministic order, current implementatio
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8232864
Webrev: http://cr.openjdk.java.net/~jiefu/8232864/webrev.00/
To find out how to reproduce this bug, please refer to the JBS.
To keep things sorted in a deterministic order, current implementation
seems to be dependent on a defaul
14 matches
Mail list logo
