Re: RFR: 8223078: Add microbenchmark for array copying/clearing/resizing

2019-04-30 Thread Claes Redestad
I think these benchmarks looks OK. Thanks for doing this! /Claes On 2019-04-30 20:15, Martin Buchholz wrote: Webrev updated. More comments. I now use     @Param("999")     public int size; All values of @Param are plausible, so only including one representative one.

Re: RFR: 8223078: Add microbenchmark for array copying/clearing/resizing

2019-04-30 Thread Martin Buchholz
Webrev updated. More comments. I now use @Param("999") public int size; All values of @Param are plausible, so only including one representative one.

Re: RFR: 8223078: Add microbenchmark for array copying/clearing/resizing

2019-04-30 Thread Martin Buchholz
On Mon, Apr 29, 2019 at 2:56 PM Claes Redestad wrote: > > This should work: > > make test TEST="micro:foo" MICRO="OPTIONS=-p SIZE=1024,2048" > Thanks for the help! Something like this should go into doc/testing.md I found that running one value of the param at a time works best for me: (cd $(

Re: RFR: 8223078: Add microbenchmark for array copying/clearing/resizing

2019-04-29 Thread Claes Redestad
On 2019-04-29 19:03, Martin Buchholz wrote: On Mon, Apr 29, 2019 at 9:49 AM Doug Lea > wrote: On 4/29/19 12:39 PM, Martin Buchholz wrote: > 8223078: Add microbenchmark for array copying/clearing/resizing > https://cr.openjdk.java.net/~martin/webrevs/

Re: RFR: 8223078: Add microbenchmark for array copying/clearing/resizing

2019-04-29 Thread Martin Buchholz
On Mon, Apr 29, 2019 at 9:49 AM Doug Lea wrote: > On 4/29/19 12:39 PM, Martin Buchholz wrote: > > 8223078: Add microbenchmark for array copying/clearing/resizing > > https://cr.openjdk.java.net/~martin/webrevs/jdk/ArrayFiddle-jmh/ > > https://bugs.openjdk.java.net/browse/JDK-8223078 > > > > Looks

Re: RFR: 8223078: Add microbenchmark for array copying/clearing/resizing

2019-04-29 Thread Doug Lea
On 4/29/19 12:39 PM, Martin Buchholz wrote: > 8223078: Add microbenchmark for array copying/clearing/resizing > https://cr.openjdk.java.net/~martin/webrevs/jdk/ArrayFiddle-jmh/ > https://bugs.openjdk.java.net/browse/JDK-8223078 > Looks good, although even more informative would be to try some dif

RFR: 8223078: Add microbenchmark for array copying/clearing/resizing

2019-04-29 Thread Martin Buchholz
8223078: Add microbenchmark for array copying/clearing/resizing https://cr.openjdk.java.net/~martin/webrevs/jdk/ArrayFiddle-jmh/ https://bugs.openjdk.java.net/browse/JDK-8223078