On Mon, 8 Nov 2021 19:59:27 GMT, Mandy Chung wrote:
> I think we should close this RFE as will not fix.
Will do.
Thank you Alan and Mandy for your time on reviewing this.
-
PR: https://git.openjdk.java.net/jdk/pull/6292
On Mon, 8 Nov 2021 19:49:06 GMT, Alan Bateman wrote:
> I'm uncomfortable with this change, does the change have any benefit?
To me, the initial appeal of this change was to use a more natural API instead
of creating an `Exception` instance and printing the stacktrace from it.
Performance wise,
On Mon, 8 Nov 2021 16:05:12 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which seeks to implement the
>> enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8153133?
>>
>> The commit in this PR uses the `StackWalker` API to dump the stacktrace of
>> the thread
On Mon, 8 Nov 2021 15:54:58 GMT, Jaikiran Pai wrote:
>>> The recursive initialisation issue will require discussion to see if we can
>>> avoid StackWalker.getInstance return null (which I assume is masking the
>>> issue).
>>
>> For a better context, here's the stacktrace of such a call to
>>
> Can I please get a review of this change which seeks to implement the
> enhancement noted in https://bugs.openjdk.java.net/browse/JDK-8153133?
>
> The commit in this PR uses the `StackWalker` API to dump the stacktrace of
> the thread. A few things to note about this change:
>
> - Previously,