Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-07 Thread Daniel D. Daugherty
On 8/7/18 2:29 AM, Alan Bateman wrote: On 06/08/2018 17:49, Daniel D. Daugherty wrote: : +java/net/Socket/LingerTest.java 8208690 generic-all +sun/net/www/http/HttpClient/MultiThreadTest.java 8208690 generic-all +  

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Alan Bateman
On 06/08/2018 17:49, Daniel D. Daugherty wrote: : +java/net/Socket/LingerTest.java 8208690 generic-all +sun/net/www/http/HttpClient/MultiThreadTest.java 8208690 generic-all +   Can these tests be changed to /othervm i

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Daniel D. Daugherty
On 8/6/18 1:41 PM, Vladimir Kozlov wrote: On 8/6/18 10:25 AM, Daniel D. Daugherty wrote: On 8/6/18 1:14 PM, Vladimir Kozlov wrote: Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use /othervm): "Tests that don't manage their threads

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Daniel D. Daugherty
On 8/6/18 1:52 PM, Vladimir Kozlov wrote: On 8/6/18 10:43 AM, Daniel D. Daugherty wrote: On 8/6/18 1:41 PM, Vladimir Kozlov wrote: On 8/6/18 10:25 AM, Daniel D. Daugherty wrote: On 8/6/18 1:14 PM, Vladimir Kozlov wrote: Okay, I read more about what happened. I think compiler tests should be m

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Vladimir Kozlov
On 8/6/18 10:43 AM, Daniel D. Daugherty wrote: On 8/6/18 1:41 PM, Vladimir Kozlov wrote: On 8/6/18 10:25 AM, Daniel D. Daugherty wrote: On 8/6/18 1:14 PM, Vladimir Kozlov wrote: Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use /oth

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Daniel D. Daugherty
On 8/6/18 1:41 PM, Vladimir Kozlov wrote: On 8/6/18 10:25 AM, Daniel D. Daugherty wrote: On 8/6/18 1:14 PM, Vladimir Kozlov wrote: Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use /othervm): "Tests that don't manage their threads

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Vladimir Kozlov
On 8/6/18 10:25 AM, Daniel D. Daugherty wrote: On 8/6/18 1:14 PM, Vladimir Kozlov wrote: Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use /othervm): "Tests that don't manage their threads properly (ie ensure they terminate at test

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Daniel D. Daugherty
On 8/6/18 1:14 PM, Vladimir Kozlov wrote: Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use /othervm): "Tests that don't manage their threads properly (ie ensure they terminate at test end) should be run in othervm mode. jtreg can't

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Vladimir Kozlov
Okay, I read more about what happened. I think compiler tests should be modified as David Holmes suggested (use /othervm): "Tests that don't manage their threads properly (ie ensure they terminate at test end) should be run in othervm mode. jtreg can't know how to make these threads terminate."

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Daniel D. Daugherty
On 8/6/18 12:59 PM, Vladimir Kozlov wrote: Hi Dan, 8208690 lists only next 2 tests: sun/net/www/http/HttpClient/MultiThreadTest.java (4 instances) java/net/Socket/LingerTest.java (2 instances) Why you also added 2 compiler tests? If you look at all the sightings in the bug report, you'll see

Re: RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Vladimir Kozlov
Hi Dan, 8208690 lists only next 2 tests: sun/net/www/http/HttpClient/MultiThreadTest.java (4 instances) java/net/Socket/LingerTest.java (2 instances) Why you also added 2 compiler tests? Thanks, Vladimir On 8/6/18 9:49 AM, Daniel D. Daugherty wrote: Greetings, I'm in the process of reducing

RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690

2018-08-06 Thread Daniel D. Daugherty
Greetings, I'm in the process of reducing the noise in the JDK12 CI so I need a single (R)eviewer for the following fix:     JDK-8209018 ProblemList tests affected by JDK-8208690     https://bugs.openjdk.java.net/browse/JDK-8209018 Here's the diff: $ hg diff diff -r c00451b67854 test/hotspot/j