ndia/IBM
Date: 07/13/2020 07:13PM
Cc: core-libs-dev@openjdk.java.net
Subject: Re: [EXTERNAL] Re: RFR 6470126 java.util.jar.Attributes#containsKey
fails with Strings
Hi Lance
Thanks for the detailed review. I will go ahead and look into the required
documentation changes.
Th
-dev@openjdk.java.net
Subject: [EXTERNAL] Re: RFR 6470126 java.util.jar.Attributes#containsKey fails
with Strings
Hi Vipin,
Apologies for the delay.
After looking at the bug, which is over 14 years old, the SCCS history of
Attributes.java, I am reluctant to suggest we move forward with
gt; Date: 06/15/2020 11:52AM
> Subject: Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with
> Strings
>
> Hi,
>
> I have addressed the review comments and the patch has been uploaded here:
>
> http://cr.openjdk.java.net/~vtewari/6470126/we
n MV
-Vipin Mv1/India/IBM wrote: -
To: core-libs-dev@openjdk.java.net
From: Vipin Mv1/India/IBM
Date: 06/15/2020 11:52AM
Subject: Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings
Hi,
I have addressed the review comm
Hi,
I have addressed the review comments and the patch has been uploaded here:
http://cr.openjdk.java.net/~vtewari/6470126/webrev/index.html
Please let me know your suggestions.
Thanks & Regards
Vipin MV
Hi,
Thanks for the review comments. I will work on the same and get back with the
same soon.
Thanks & Regards
Vipin MV
Hi Vipin,
When you submit your revised patch addressing the input previously provided,
please include a test case which exercises the various methods.
Best
Lance
> On May 11, 2020, at 7:54 AM, Alan Bateman wrote:
>
> On 11/05/2020 12:44, Claes Redestad wrote:
>> Hi Vipin,
>>
>> making cont
On 11/05/2020 12:44, Claes Redestad wrote:
Hi Vipin,
making containsKey("key") return true without also ensuring the
other Map operations like get, put, .. work consistently and
transparently with String keys seem like a partial fix that will subtly
break operations like getOrDefault.
Yeah, I th
Hi Vipin,
making containsKey("key") return true without also ensuring the
other Map operations like get, put, .. work consistently and
transparently with String keys seem like a partial fix that will subtly
break operations like getOrDefault.
And why not "if (name instanceof String)"?
Thanks!
