Re: Please review: 7151434: java -jar -XX crashes java launcher

2012-04-24 Thread Joe Darcy
Hi Kumar, The launcher changes looks fine, but I recommend generally documenting the null-handling protocol in these sort of functions. We generally don't include bug ids in the next of the test, but I see the test file does that in other areas. Cheers, -Joe On 04/24/2012 08:24 AM, Kumar

Re: Please review: 7151434: java -jar -XX crashes java launcher

2012-04-24 Thread Mandy Chung
Looks good to me. Mandy On 4/24/2012 8:24 AM, Kumar Srinivasan wrote: Hi, Could you please review this, actually the launcher is a 2 line change, but when I was testing/experimenting with this, it was hard to inspect the .jtr file for test failure, the test framework is cleanup to help the re

Please review: 7151434: java -jar -XX crashes java launcher

2012-04-24 Thread Kumar Srinivasan
Hi, Could you please review this, actually the launcher is a 2 line change, but when I was testing/experimenting with this, it was hard to inspect the .jtr file for test failure, the test framework is cleanup to help the reader quickly identify the failing test cases. http://cr.openjdk.java.net