va.net/%7Emartin/webrevs/openjdk7/Formatter.parse/>
Synopsis: Optimize Formatter.parse (including String.printf)
Description:
Formatter is not as efficient as it could be.
Here's a low-hanging fruit optimization
that creates fewer objects,
and uses the idiom
return al.toArray(new FormatStrin
t; if (f.contains(Flags.ALTERNATE))
>>
>> FormatConversion is an inner class, so already has
>> a pointer to its enclosing instance - no need to provide
>> an additional explicit one.
>>
>> Martin
>>
>>>
>>>
>>> The rest loo
gt;
> Martin
>
>>
>>
>> The rest looks fine.
>>
>> sherman
>>
>>
>> Martin Buchholz wrote:
>>>
>>> Hi Sherman,
>>>
>>> I'd like you to do a code review.
>>>
>>> http://cr.openjdk.java.net/~
;
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Formatter.parse/
>> <http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk7/Formatter.parse/>
>>
>> Synopsis: Optimize Formatter.parse (including String.printf)
>> Description:
>> Formatter is not as efficie
s: Optimize Formatter.parse (including String.printf)
Description:
Formatter is not as efficient as it could be.
Here's a low-hanging fruit optimization
that creates fewer objects,
and uses the idiom
return al.toArray(new FormatString[al.size()]);
I'm sure additional optimizations are possible
Hi Sherman,
I'd like you to do a code review.
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/Formatter.parse/
Synopsis: Optimize Formatter.parse (including String.printf)
Description:
Formatter is not as efficient as it could be.
Here's a low-hanging fruit optimization
that cre