Re: LinkedList facelift

2009-11-04 Thread Rémi Forax
Le 04/11/2009 19:25, Martin Buchholz a écrit : On Wed, Nov 4, 2009 at 06:18, Rémi Forax > wrote: Good for me if addFirst() calls linkFirst() and addLast() calls linkLast(). Sigh. Of course, that's what I intended to do. Done. Also, renamed addBefore to l

Re: LinkedList facelift

2009-11-04 Thread Martin Buchholz
On Wed, Nov 4, 2009 at 06:18, Rémi Forax wrote: > Good for me if addFirst() calls linkFirst() and > addLast() calls linkLast(). > > Sigh. Of course, that's what I intended to do. Done. Also, renamed addBefore to linkBefore and moved near to the other linkXXX methods. Webrev regenerated. Tha

Re: LinkedList facelift

2009-11-04 Thread Rémi Forax
Le 03/11/2009 20:32, Martin Buchholz a écrit : On Tue, Nov 3, 2009 at 01:06, Rémi Forax > wrote: Hi Martin, Your patch can break backward compat. add(E) now delegates to a public method (an overridable one) (addLast). So If I have a class that inheri

Re: LinkedList facelift

2009-11-03 Thread Martin Buchholz
On Tue, Nov 3, 2009 at 01:06, Rémi Forax wrote: > Hi Martin, > Your patch can break backward compat. > > add(E) now delegates to a public method (an overridable one) > (addLast). So If I have a class that inherits from LinkedList > and overrides addLast() the current semantics of add(E) is not al

Re: LinkedList facelift

2009-11-03 Thread Christopher Hegarty -Sun Microsystems Ireland
- there are so many more important things to work on, and no one is really using LinkedList in performance-sensitive production code, eh? Chris, could you file a bug? Happy to do so. CR 6897553: LinkedList facelift -Chris. Synopsis: LinkedList facelift Description: - A list of size N

Re: LinkedList facelift

2009-11-03 Thread Rémi Forax
) I apologize for this - there are so many more important things to work on, and no one is really using LinkedList in performance-sensitive production code, eh? Chris, could you file a bug? Synopsis: LinkedList facelift Description: - A list of size N should create only N+1 objects, not N+2

Re: LinkedList facelift

2009-11-02 Thread Martin Buchholz
On Mon, Nov 2, 2009 at 18:29, Martin Buchholz wrote: > I would like to contribute an improvement to LinkedList > > Below is a stupid microbenchmark demonstrating app. a factor of 2 improvement > in > "throughput", and a 50% increase in memory footprint. Of course, I meant "a 50% improvement in m

LinkedList facelift

2009-11-02 Thread Martin Buchholz
important things to work on, and no one is really using LinkedList in performance-sensitive production code, eh? Chris, could you file a bug? Synopsis: LinkedList facelift Description: - A list of size N should create only N+1 objects, not N+2. - Use of null as sentinel value instead of a sentinel