Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-09 Thread Eamonn McManus
While you are at it, ... is a lot simpler than Éamonn 2013/7/8 Joe Darcy > > PS Updated webrev so that the ... structure don't have an > empty "..." portion. > > http://cr.openjdk.java.net/~darcy/8020095.1/ > > -Joe > > > On 07/08/2013 07:10 PM, Joe Darcy wrote: >> >> Hello, >> >> Ple

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-09 Thread Lance Andersen - Oracle
Looks fine Joe including Mandy's feedback Best Lance On Jul 8, 2013, at 10:10 PM, Joe Darcy wrote: > Hello, > > Please review my changes to resolve (almost all of): > >JDK-8020095 Fix doclint warnings in java.util.regex >http://cr.openjdk.java.net/~darcy/8020095.0/ > > Full text of the

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Joe Darcy
On 07/08/2013 10:23 PM, Mandy Chung wrote: On 7/8/2013 7:10 PM, Joe Darcy wrote: Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex http://cr.openjdk.java.net/~darcy/8020095.0/ I think line 32 in Matcher.java should be {@

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Mandy Chung
On 7/8/2013 7:10 PM, Joe Darcy wrote: Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex http://cr.openjdk.java.net/~darcy/8020095.0/ I think line 32 in Matcher.java should be {@linkplain ...} instead of {@link ...} /*

Re: JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Joe Darcy
PS Updated webrev so that the ... structure don't have an empty "..." portion. http://cr.openjdk.java.net/~darcy/8020095.1/ -Joe On 07/08/2013 07:10 PM, Joe Darcy wrote: Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex

JDK 8 code review request for JDK-8020095: Fix doclint warnings in java.util.regex

2013-07-08 Thread Joe Darcy
Hello, Please review my changes to resolve (almost all of): JDK-8020095 Fix doclint warnings in java.util.regex http://cr.openjdk.java.net/~darcy/8020095.0/ Full text of the patch also included below. For some reason I have not been able to determine, even with the patch, one error re